[API2.0] add op for cudnn version query test=develop #26180
Conversation
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
wangchaochaohu
changed the title
| self.assertEqual((cudnn_version is None), True) | ||
|
|
||
| def test_cudnn(self): | ||
| cudnn_version = paddle.cudnn_version() |
There was a problem hiding this comment.
wo don't know ci machine cudnn version
There was a problem hiding this comment.
at least check if it returns an integer?
python/paddle/device.py
Outdated
| ] | ||
|
|
||
|
|
||
| def cudnn_version(): |
There was a problem hiding this comment.
rename to get_cudnn_version() to signify that it is a function not a variable?
| self.assertEqual((cudnn_version is None), True) | ||
|
|
||
| def test_cudnn(self): | ||
| cudnn_version = paddle.cudnn_version() |
There was a problem hiding this comment.
at least check if it returns an integer?
|
|
||
|
|
||
| class TestCudnnVersion(unittest.TestCase): | ||
| def test_no_cudnn(self): |
There was a problem hiding this comment.
this can be merged into the test below, since you can not test both case in one go.
| @@ -73,6 +74,10 @@ int GetCUDADeviceCount() { | |||
| return dev_cnt; | |||
| } | |||
|
|
|||
| /* Here is a very simple CUDA “pro tip”: cudaDeviceGetAttribute() is a much | |||
There was a problem hiding this comment.
why is this comment here? looks like that cudaDeviceGetAttribute is not used anyway
There was a problem hiding this comment.
This comment is for GetCUDAComputeCapability, I change it to right position by the way
| ] | ||
|
|
||
|
|
||
| def get_cudnn_version(): |
There was a problem hiding this comment.
the return value should be cached, as it will never change and this function may be called on each step for each OP that use it in dygraph mode.
wangchaochaohu
dismissed stale reviews from heavengate and willthefrog
via
51cda85
wangchaochaohu
changed the title
PR types
New features
PR changes
APIs
Describe
Add cudnn version query: def get_cudnn_version
this api return the version of cudnn.