Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conv_transpose api #26427

Merged
merged 8 commits into from
Aug 22, 2020
Merged

Conversation

LielinJiang
Copy link
Contributor

@LielinJiang LielinJiang commented Aug 19, 2020

PR types

New features

PR changes

APIs

Describe

Update conv_transpose2d, conv_transpose3d, ConvTranspose2d, ConvTranspose3d api

TODO:

  1. 支持output_size为tensor的输入(静态图)。
  2. 经过粗略的测试与竞品参考(tf),目前use_cudnn在使用depthwise默认会设置为false,并且使用depthwise_conv_transpose op。后续可能任然需要更多的测试。部分测试数据如下:
    image
    image
    image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
paddle/fluid/operators/conv_transpose_op.cc Show resolved Hide resolved
paddle/fluid/operators/conv_transpose_op.cc Show resolved Hide resolved
python/paddle/nn/functional/conv.py Show resolved Hide resolved
Copy link
Contributor

@willthefrog willthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference, maybe add the reasoning and bench result of use_cudnn setting to PR description

also, the code does not seem to be DRY enough, consider:

  • extract conv_nd function
  • reference to class description in functional docstring

python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/conv.py Show resolved Hide resolved
Copy link
Contributor

@willthefrog willthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need subsequent PR to add tensor input for output_size, otherwise LGTM

@LielinJiang LielinJiang merged commit d26ae9a into PaddlePaddle:develop Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants