Skip to content

【Hackathon 9th No.68】supplementary unit test for ngram_match #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 8, 2025
Merged

【Hackathon 9th No.68】supplementary unit test for ngram_match #3732

merged 9 commits into from
Sep 8, 2025

Conversation

@Echo-Nie
Copy link
Contributor

@Echo-Nie Echo-Nie commented Aug 30, 2025 

draft_tokens_out: [[ 0 50 60  0  0  0]]
seq_lens_this_time_out: [3]
.
draft_tokens_out: [[0 0 0 0]]
seq_lens_this_time_out: [1]
.
----------------------------------------------------------------------
Ran 2 tests in 0.002s

@paddle-bot
Copy link

paddle-bot bot commented Aug 30, 2025

Thanks for your contribution!

@paddle-bot paddle-bot bot added the contributor External developers label Aug 30, 2025
@luotao1 luotao1 mentioned this pull request Sep 1, 2025
Open
freeliuzc
freeliuzc reviewed Sep 2, 2025
View reviewed changes
tests/operators/test_ngram_match.py Outdated
print("seq_lens_this_time_out:", seq_lens_this_time.numpy())

# Check if draft tokens are correctly extracted
self.assertIn(50, draft_tokens.numpy()[0])
Copy link
Collaborator

@freeliuzc freeliuzc Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里借助 step_idx 信息，改为在具体位置判断是否相等

Copy link
Contributor Author

@Echo-Nie Echo-Nie Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里借助 step_idx 信息，改为在具体位置判断是否相等

Thx, Done

freeliuzc
freeliuzc reviewed Sep 3, 2025
View reviewed changes
tests/operators/test_ngram_match.py Outdated
4,
)

# print("step_idx:", step_idx.numpy())
Copy link
Collaborator

@freeliuzc freeliuzc Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦删除注释

Copy link
Contributor Author

@Echo-Nie Echo-Nie Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx

tests/operators/test_ngram_match.py Outdated
3,
)

print("draft_tokens_out:", draft_tokens.numpy())
Copy link
Collaborator

@freeliuzc freeliuzc Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦删除注释

Copy link
Contributor Author

@Echo-Nie Echo-Nie Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Thx

@freeliuzc
Copy link
Collaborator

freeliuzc commented Sep 3, 2025

逻辑已没问题，删除注释后，CI过了合入

@Echo-Nie
Copy link
Contributor Author

Echo-Nie commented Sep 7, 2025

Maybe this PR is ready to be merged. @luotao1

@freeliuzc freeliuzc merged commit 20495f9 into PaddlePaddle:develop Sep 8, 2025
15 of 17 checks passed
@Echo-Nie Echo-Nie deleted the ngr branch October 17, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freeliuzc freeliuzc freeliuzc approved these changes

Assignees

@luotao1 luotao1

@freeliuzc freeliuzc

Labels

contributor External developers PaddlePaddle Hackathon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Echo-Nie @freeliuzc @luotao1