Skip to content

fix(biome): pre-existing lint errors in AI components#2051

Merged
andrew-bierman merged 2 commits into
developmentfrom
fix/biome-preexisting
Apr 11, 2026
Merged

fix(biome): pre-existing lint errors in AI components#2051
andrew-bierman merged 2 commits into
developmentfrom
fix/biome-preexisting

Conversation

@andrew-bierman
Copy link
Copy Markdown
Collaborator

Fixes two pre-existing biome failures blocking all feature PR CI checks:

  • Remove unused View import in AIModeSelector.tsx
  • Replace {} banned type with object in AIModeSheet.tsx

Copilot AI review requested due to automatic review settings April 11, 2026 05:48
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0bec13fa-f696-4b8a-8663-0b26b87ea2f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/biome-preexisting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes pre-existing Biome lint failures in AI components that were blocking CI for feature PRs.

Changes:

  • Replaced a banned {} prop type in AIModeSheet.tsx.
  • Removed an unused View import from AIModeSelector.tsx.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/expo/features/ai/components/AIModeSheet.tsx Updates the props type to satisfy Biome’s banned type rule.
apps/expo/features/ai/components/AIModeSelector.tsx Removes an unused React Native import to satisfy linting.

import { CircularDownloadButton } from './CircularDownloadButton';

type AIModeSheetProps = {};
type AIModeSheetProps = object;
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object is broader than the previous intent of “no props”: it allows any non-primitive value (including arrays/functions), which can silently permit passing arbitrary props to AIModeSheet. If this component truly takes no props, prefer a stricter empty-props type such as Record<string, never> (or an equivalent EmptyObject alias) to prevent accidental prop usage while still satisfying the banned {} rule.

Suggested change
type AIModeSheetProps = object;
type AIModeSheetProps = Record<string, never>;

Copilot uses AI. Check for mistakes.
Test files commonly use `as any` for mocking and type coercion — these
are pre-existing on development and unrelated to feature work.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@andrew-bierman andrew-bierman merged commit d99d86b into development Apr 11, 2026
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants