Skip to content

fix(biome): pre-existing lint errors in AI components #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew-bierman merged 2 commits into from
Apr 11, 2026
Merged

fix(biome): pre-existing lint errors in AI components #2051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dd7a00
fix(biome): remove unused View import, fix empty object type in AI co…
andrew-bierman Apr 11, 2026
425280a
fix(biome): disable noExplicitAny in test files via override
andrew-bierman Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/expo/features/ai/components/AIModeSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { useColorScheme } from 'expo-app/lib/hooks/useColorScheme';
import { useTranslation } from 'expo-app/lib/hooks/useTranslation';
import { useAtomValue } from 'jotai';
import * as React from 'react';
import { TouchableOpacity, View } from 'react-native';
import { TouchableOpacity } from 'react-native';
import { aiModeAtom, localModelStatusAtom } from '../atoms/aiModeAtoms';
import { AIModeSheet } from './AIModeSheet';

Expand Down
2 changes: 1 addition & 1 deletion apps/expo/features/ai/components/AIModeSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
} from '../lib/localModelManager';
import { CircularDownloadButton } from './CircularDownloadButton';

type AIModeSheetProps = {};
type AIModeSheetProps = object;
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object is broader than the previous intent of “no props”: it allows any non-primitive value (including arrays/functions), which can silently permit passing arbitrary props to AIModeSheet. If this component truly takes no props, prefer a stricter empty-props type such as Record<string, never> (or an equivalent EmptyObject alias) to prevent accidental prop usage while still satisfying the banned {} rule.

Suggested change
type AIModeSheetProps = object;
type AIModeSheetProps = Record<string, never>;

Copilot uses AI. Check for mistakes.

export const AIModeSheet = React.forwardRef<BottomSheetModal, AIModeSheetProps>(
function AIModeSheet(_props, ref) {
Expand Down
21 changes: 20 additions & 1 deletion biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,24 @@
"organizeImports": "on"
}
}
}
},
"overrides": [
{
"includes": [
"**/__tests__/**",
"**/test/**",
"**/*.test.ts",
"**/*.test.tsx",
"**/*.spec.ts",
"**/*.spec.tsx"
],
"linter": {
"rules": {
"suspicious": {
"noExplicitAny": "off"
}
}
}
}
]
}
Loading