Skip to content

fix: remove orphaned migration files causing api-tests failure #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikib0 merged 5 commits into from
Apr 10, 2026
Merged

fix: remove orphaned migration files causing api-tests failure #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6eb3b3c
fix: remove orphaned migration file causing duplicate column error
Copilot Apr 9, 2026
35983ce
fix: remove second orphaned migration file (0010_flashy_human_robot)
Copilot Apr 9, 2026
6320f64
Merge branch 'development' into copilot/fix-api-tests-job-failing
mikib0 Apr 9, 2026
af85d54
chore(api): separate integration and unit tests in vitest config
mikib0 Apr 10, 2026
3baae2d
chore(api): update test for pack generation from tiktok to match actu…
mikib0 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/api/drizzle/0010_flashy_human_robot.sql
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/api/drizzle/0033_add_avatar_url_to_users.sql
View file
Open in desktop

This file was deleted.

40 changes: 20 additions & 20 deletions ...ges/api/test/generate-from-tiktok.test.ts → ...test/generate-from-online-content.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ vi.mock('@packrat/api/services/catalogService', () => ({
})),
}));

describe('Generate From TikTok Routes', () => {
describe('Generate From Online Content Routes', () => {
beforeAll(async () => {
// Seed both a regular user and an admin user
await seedTestUser();
Expand All @@ -139,11 +139,11 @@ describe('Generate From TikTok Routes', () => {
});

describe('Authentication', () => {
it('requires auth for generate-from-tiktok endpoint', async () => {
it('requires auth for generate-from-online-content endpoint', async () => {
const res = await api(
'/pack-templates/generate-from-tiktok',
'/pack-templates/generate-from-online-content',
httpMethods.post('', {
tiktokUrl: 'https://www.tiktok.com/@user/video/1234567890',
contentUrl: 'https://www.tiktok.com/@user/video/1234567890',
}),
);
expectUnauthorized(res);
Expand All @@ -153,9 +153,9 @@ describe('Generate From TikTok Routes', () => {
describe('Authorization', () => {
it('returns 403 for non-admin users', async () => {
const res = await apiWithAuth(
'/pack-templates/generate-from-tiktok',
'/pack-templates/generate-from-online-content',
httpMethods.post('', {
tiktokUrl: 'https://www.tiktok.com/@user/video/1234567890',
contentUrl: 'https://www.tiktok.com/@user/video/1234567890',
}),
);

Expand All @@ -166,19 +166,19 @@ describe('Generate From TikTok Routes', () => {
});

describe('Request Validation', () => {
it('requires tiktokUrl field', async () => {
it('requires contentUrl field', async () => {
const res = await apiWithAdmin(
'/pack-templates/generate-from-tiktok',
'/pack-templates/generate-from-online-content',
httpMethods.post('', {}),
);
expectBadRequest(res);
});

it('requires valid URL format', async () => {
const res = await apiWithAdmin(
'/pack-templates/generate-from-tiktok',
'/pack-templates/generate-from-online-content',
httpMethods.post('', {
tiktokUrl: 'not-a-valid-url',
contentUrl: 'invalid-url',
}),
);
expectBadRequest(res);
Expand All @@ -200,9 +200,9 @@ describe('Generate From TikTok Routes', () => {
mockContainerFetch = createMockContainerFetch(duplicateContentId);

const res = await apiWithAdmin(
'/pack-templates/generate-from-tiktok',
'/pack-templates/generate-from-online-content',
httpMethods.post('', {
tiktokUrl: 'https://www.tiktok.com/@user/video/1234567890',
contentUrl: 'https://www.tiktok.com/@user/video/1234567890',
}),
);

Expand All @@ -214,12 +214,12 @@ describe('Generate From TikTok Routes', () => {
});
});

describe('POST /pack-templates/generate-from-tiktok', () => {
it('successfully generates template from TikTok URL', async () => {
describe('POST /pack-templates/generate-from-online-content', () => {
it('successfully generates template from online content URL', async () => {
const res = await apiWithAdmin(
'/pack-templates/generate-from-tiktok',
'/pack-templates/generate-from-online-content',
httpMethods.post('', {
tiktokUrl: 'https://www.tiktok.com/@user/video/9999999999',
contentUrl: 'https://www.tiktok.com/@user/video/9999999999',
}),
);

Expand All @@ -245,9 +245,9 @@ describe('Generate From TikTok Routes', () => {

it('accepts isAppTemplate flag', async () => {
const res = await apiWithAdmin(
'/pack-templates/generate-from-tiktok',
'/pack-templates/generate-from-online-content',
httpMethods.post('', {
tiktokUrl: 'https://www.tiktok.com/@user/video/6666666666',
contentUrl: 'https://www.tiktok.com/@user/video/temp-test',
isAppTemplate: false,
}),
);
Expand All @@ -259,9 +259,9 @@ describe('Generate From TikTok Routes', () => {

it('returns items with matched catalog data when available', async () => {
const res = await apiWithAdmin(
'/pack-templates/generate-from-tiktok',
'/pack-templates/generate-from-online-content',
httpMethods.post('', {
tiktokUrl: 'https://www.tiktok.com/@user/video/5555555555',
contentUrl: 'https://www.tiktok.com/@user/video/catalog-test',
}),
);

Expand Down
2 changes: 2 additions & 0 deletions packages/api/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export default defineWorkersConfig({
wrangler: { configPath: './wrangler.jsonc', environment: 'dev' },
},
},
// Only include integration tests from /test directory
include: [resolve(__dirname, 'test/**/*.test.ts')],
// Run tests sequentially to avoid database deadlocks
fileParallelism: false,
// Also disable parallel execution within test files
Expand Down
Loading