fix: resolve TypeScript check-types CI errors by andrew-bierman · Pull Request #1985 · PackRat-AI/PackRat

andrew-bierman · 2026-03-19T14:18:14Z

Summary

Rename deprecated ref types: AlertRef → AlertMethods, LargeTitleSearchBarRef → LargeTitleSearchBarMethods, ContextMenuRef → ContextMenuMethods
Switch useColorScheme import to app-level hook (expo-app/lib/hooks/useColorScheme) where colors.green/colors.yellow are needed — no hardcoded RGB values
Update icon names to SF Symbols (nativewindui auto-maps to Material on Android via rn-icon-mapper)
Remove deprecated namingScheme prop from icon objects
Update List component: rootStyle/rootClassName → style/className
Fix SearchInputRef → TextInput ref type
Add missing Share import in TripDetailScreen
Update lockfile: @packrat-ai/nativewindui rc.3 → 2.0.1

CI Status

✅ check-types passes
✅ biome passes
⚠️ E2E flaky (also failing on development — infra issue, not code)

Supersedes #1984

🤖 Generated with Claude Code

Update types and imports to match @packrat-ai/nativewindui v2.0.0 API: - AlertRef -> AlertMethods (18 files) - LargeTitleSearchBarRef -> LargeTitleSearchBarMethods (4 files) - ContextMenuRef -> ContextMenuMethods (1 file) - Use SfSymbol names for context/dropdown menu icons - Switch useColorScheme import to local hook for files using colors.green/yellow - Replace rootStyle/rootClassName with style/className on List - Fix SearchInputRef usage with TextInput ref type - Fix invalid icon names (person-outline, backpack) - Remove unsupported namingScheme property - Add missing Share import from react-native

coderabbitai · 2026-03-19T14:18:44Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 153a50c4-7863-42ab-88f8-7af3fd7d3ddb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/check-types-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Resolves bun check-types CI failures in the Expo app after upgrading to @packrat-ai/nativewindui v2 by updating renamed method/ref types, aligning icon prop types, and switching theme hook imports where app-specific colors are required.

Changes:

Replaced deprecated ref/method types (AlertRef, LargeTitleSearchBarRef, ContextMenuRef) with the new *Methods equivalents across screens/components.
Updated context menu / dropdown menu icon names to SF Symbol names and removed unsupported namingScheme usage.
Adjusted theming and component props to match v2 APIs (e.g., local useColorScheme where colors.green/yellow are needed; List rootStyle/rootClassName → style/className; corrected missing imports like Share).

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
apps/expo/features/weather/screens/LocationSearchScreen.tsx	Updates `SearchInput` ref typing to match v2 API expectations.
apps/expo/features/weather/components/WeatherAlertsTile.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/trips/screens/TripListScreen.tsx	Updates LargeTitle search bar ref type to `LargeTitleSearchBarMethods`.
apps/expo/features/trips/screens/TripDetailScreen.tsx	Updates alert ref type and adds missing `Share` import used by share handler.
apps/expo/features/trips/components/UpcomingTripsTile.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/trips/components/TripCard.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/trips/components/TrailConditionsTile.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/packs/screens/PackListScreen.tsx	Updates LargeTitle search bar ref type to `LargeTitleSearchBarMethods`.
apps/expo/features/packs/components/WeightAnalysisTile.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/packs/components/PackStatsTile.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/packs/components/PackCategoriesTile.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/packs/components/HorizontalCatalogItemCard.tsx	Switches `useColorScheme` to app hook for app-specific colors.
apps/expo/features/packs/components/GearInventoryTile.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/packs/components/GapSuggestion.tsx	Switches `useColorScheme` to app hook for app-specific colors.
apps/expo/features/pack-templates/screens/PackTemplateListScreen.tsx	Updates LargeTitle search bar ref type to `LargeTitleSearchBarMethods`.
apps/expo/features/auth/components/DeleteAccountButton.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/features/ai/components/WebSearchGenerativeUI.tsx	Switches `useColorScheme` to app hook for app-specific colors.
apps/expo/features/ai-packs/screens/AIPacksScreen.tsx	Updates alert ref type and aligns alert icon naming with updated types.
apps/expo/app/auth/one-time-password.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/app/auth/index.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/app/auth/(login)/reset-password.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/app/auth/(login)/forgot-password.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/app/auth/(create-account)/credentials.tsx	Updates alert ref type to `AlertMethods`.
apps/expo/app/_layout.tsx	Updates global app alert ref type to `AlertMethods`.
apps/expo/app/(app)/settings/index.android.tsx	Updates `List` props to v2 (`rootStyle/rootClassName` → `style/className`).
apps/expo/app/(app)/messages/conversations.tsx	Updates dropdown/context menu icon names and removes `namingScheme`.
apps/expo/app/(app)/messages/conversations.android.tsx	Updates dropdown/toolbar icon names and removes `namingScheme`.
apps/expo/app/(app)/messages/chat.tsx	Updates `ContextMenu` ref type to `ContextMenuMethods` and icon names.
apps/expo/app/(app)/messages/chat.android.tsx	Updates dropdown icon names to SF Symbol names.
apps/expo/app/(app)/(tabs)/profile/name.tsx	Updates `FormSection` icon name to match updated icon typing.
apps/expo/app/(app)/(tabs)/profile/index.tsx	Updates alert ref type and switches `useColorScheme` to app hook for app-specific colors.
apps/expo/app/(app)/(tabs)/(home)/index.tsx	Updates LargeTitle search bar ref type to `LargeTitleSearchBarMethods`.

You can also share your feedback on Copilot code review. Take the survey.

…pmrc

* development: (68 commits) apply safe area top inset only on iOS chore(expo): update android resource class to 'large' and adjust gradle and JVM options chore(e2e): update iOS E2E tests to run on macos-15 and use Xcode version 26.2 chore(e2e): update iOS E2E tests to run on macos-26-large chore(expo): correct resource class from 'm-medium' to 'medium' in eas.json chore(expo): use larger resource class and disable lint in eas builds chore(expo): increase JVM memory and set latest iOS image for builds Add itemCalculations tests - API: 24.51% → 25.4% (+0.89%) Add env-validation tests - API: 21.9% → 24.51% (+2.61%) Add comprehensive auth.ts tests - API: 19.59% → 21.9% chore: add workflow_dispatch trigger to E2E tests chore: update expo-glass-effect to SDK 54 compatible version chore: add workflow_dispatch trigger to E2E tests Exclude routes from API coverage & add auth middleware tests - API: 18.94% → 19.59% Add ImageCacheManager tests - Expo coverage: 53.45% → 70.93% Add middleware tests and more Expo utils - Expo: 31.91% → 53.45%, API: 5.12% → 5.24% Add comprehensive tests for Expo utilities - coverage 31.91% → 52.84% fix(expo/ai-chat): replace Toast with Burnt Add comprehensive unit test coverage POC for API and Expo layers Initial plan ...

cloudflare-workers-and-pages · 2026-04-09T15:29:53Z

Deploying packrat-landing with Cloudflare Pages

Latest commit:	`76f3a70`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2026-04-09T15:30:52Z

Deploying packrat-guides with Cloudflare Pages

Latest commit:	`76f3a70`
Status:	🚫 Build failed.

View logs

* development: navigate to locationdetailscreen if location added and to locationscreen if not added add padding top ios fix: use correct relative paths for coverage report action fix: add coverage reports to PRs and fix workflow issues chore(ci): run unit tests with coverage to account for thresholds Add unit tests CI workflow refactor(api): remove comment on coverage thresholds in unit test config chore(expo): add test coverage threshold chore(api): improve unit test coverage to meet threshold chore(api): refactor tests and utility functions for improved accuracy Add testing strategy documentation and finalize coverage exclusions Add unit tests for services (weatherService, embeddingService, imageDetectionService) Add tests for remaining high-priority utils (embeddingHelper, openapi) Add unit tests for utils (itemCalculations, auth, csv-utils) Add unit tests for middleware (auth, apiKeyAuth, adminMiddleware) use platform specific padding remove static import of @react-native-ai/apple chore(expo): add unit tests for image and storage utilities

github-actions · 2026-04-09T18:21:28Z

Coverage Report for Expo Unit Tests Coverage (./apps/expo)

Status	Category	Percentage	Covered / Total
🔵	Lines	95.37%	454 / 476
🔵	Statements	95.37% (🎯 75%)	454 / 476
🔵	Functions	100%	50 / 50
🔵	Branches	93.26%	180 / 193

File Coverage

No changed files found.

Generated in workflow #19 for commit 542b56f by the Vitest Coverage Report Action

github-actions · 2026-04-09T18:21:32Z

Coverage Report for API Unit Tests Coverage (./packages/api)

Status	Category	Percentage	Covered / Total
🔵	Lines	96.61%	912 / 944
🔵	Statements	96.61% (🎯 80%)	912 / 944
🔵	Functions	100%	50 / 50
🔵	Branches	90.18%	285 / 316

File Coverage

File	Stmts	Branches	Functions	Lines
Changed Files
packages/api/src/utils/auth.ts	100%	100%	100%	100%
packages/api/src/utils/typeAssertions.ts	100%	100%	100%	100%

Generated in workflow #19 for commit 542b56f by the Vitest Coverage Report Action

…omponents

fix: resolve TypeScript check-types CI errors

Copilot AI review requested due to automatic review settings March 19, 2026 14:18

Copilot AI reviewed Mar 19, 2026

View reviewed changes

andrew-bierman added 2 commits March 19, 2026 08:44

fix: update lockfile for @packrat-ai/nativewindui@2.0.1, gitignore .n…

4714658

…pmrc

fix: revert .npmrc from gitignore, not needed with bunfig.toml

265e3c9

andrew-bierman mentioned this pull request Apr 1, 2026

fix: resolve type errors from NativeWindUI 2.0.0 upgrade #1984

Closed

3 tasks

mikib0 added 2 commits April 9, 2026 19:11

refactor: fix type errors

e62c2a5

mikib0 added 2 commits April 9, 2026 19:26

refactor: fix type errors

8625eff

refactor: remove unused keyboard debug and circular download button c…

b8384fd

…omponents

Copilot AI mentioned this pull request Apr 9, 2026

fix: remove orphaned migration files causing api-tests failure #2027

Merged

7 tasks

refactor: fix type errors

542b56f

mikib0 merged commit 6b1cb3d into development Apr 9, 2026
5 of 8 checks passed

mikib0 deleted the fix/check-types-ci branch April 9, 2026 18:45

andrew-bierman pushed a commit that referenced this pull request May 14, 2026

Merge pull request #1985 from PackRat-AI/fix/check-types-ci

a7318da

fix: resolve TypeScript check-types CI errors

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve TypeScript check-types CI errors#1985

fix: resolve TypeScript check-types CI errors#1985
mikib0 merged 9 commits into
developmentfrom
fix/check-types-ci

andrew-bierman commented Mar 19, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 19, 2026 •

edited

Loading

Review skipped

Uh oh!

Copilot AI left a comment

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

andrew-bierman commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

CI Status

Uh oh!

coderabbitai Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying packrat-landing with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying packrat-guides with Cloudflare Pages

Uh oh!

github-actions Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for Expo Unit Tests Coverage (./apps/expo)

Uh oh!

github-actions Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for API Unit Tests Coverage (./packages/api)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrew-bierman commented Mar 19, 2026 •

edited

Loading

coderabbitai Bot commented Mar 19, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Apr 9, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Apr 9, 2026 •

edited

Loading

github-actions Bot commented Apr 9, 2026 •

edited

Loading

github-actions Bot commented Apr 9, 2026 •

edited

Loading