Skip to content

Comments

Fix CI issues#55

Merged
bkueng merged 4 commits intoPX4:masterfrom
ThunderFly-aerospace:fix_ci
Dec 8, 2020
Merged

Fix CI issues#55
bkueng merged 4 commits intoPX4:masterfrom
ThunderFly-aerospace:fix_ci

Conversation

@roman-dvorak
Copy link
Contributor

This PR solves two of the three problems with CI. Fixes an issue on version 3.4 and 3.5 where there was an unnecessary break in the if and elif functions and exit() instead of sys.exit().

In version 2.7 there is still issue

E: 88,12: Assigning to function call which doesn't return (assignment-from-no-return)

from line:

pitch = np.arcsin(2.0 * (q[0] * q[2] - q[3] * q[1]))

It can be related to pylint bug: pylint-dev/pylint#2694

But will python 2.7 be further supported? Official support of python 2.x ends on January 1.

Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You're right, I removed python 2 from CI in 5835c86

@roman-dvorak
Copy link
Contributor Author

break-elif mistake was repaired.

@bkueng bkueng merged commit 4354b32 into PX4:master Dec 8, 2020
@roman-dvorak roman-dvorak deleted the fix_ci branch December 8, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants