Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test unordered logs #100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hermankolden
Copy link
Contributor

A production ULog in Aviant failed comparison with the original ULog
after write_ulog, which turned out to be because of messages arriving
at different times and thus the timestamps weren't completely in order.
This isn't really a problem, so we want the tests to pass, but in order
to do that we need the option of sorting the datasets.

It will fail a test
A production ULog in Aviant failed comparison with the original ULog
after write_ulog, which turned out to be because of messages arriving
at different times and thus the timestamps weren't completely in order.
This isn't really a problem, so we want the tests to pass, but in order
to do that we need the option of sorting the datasets.
@bkueng
Copy link
Member

bkueng commented Jul 4, 2024

This is actually a problem in the writer as ulog files are required to have monotonically increasing timestamps.
It can happen though, and I'm ok with adding sorting but prefer to have it as separate method with appropriate comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants