Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PX4 Core Components & Release Workflows #3443

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mrpollo
Copy link
Contributor

@mrpollo mrpollo commented Nov 7, 2024

  • Introduces the concept of core components
  • Defines release workflow

Splits up from #2331 by @junwoo091400

@mrpollo mrpollo changed the title PX4 Core Components PX4 Core Components & Release Workflows Nov 7, 2024
* also introduces core concept list
@mrpollo mrpollo force-pushed the pr_release_procedure branch from 1ca271e to 241a975 Compare November 7, 2024 18:32
@mrpollo mrpollo requested a review from hamishwillee November 7, 2024 18:34
Comment on lines +12 to +13
- Maintainer
- Tester
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is desirable, but we haven't had a maintainer for MacOS forever, and many of these others too. So perhaps something less "must" ish

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, who is this tester?

Comment on lines +47 to +50
| Flightgear (Simulation) | | |
| JSBSim (Simulation) | | |
| jMAVSim (Simulation) | | |
| SIH (Simulation) | | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The are all community maintained. I think it might be worth listing these separately. Only SIH has a maintainer, of sorts.

Suggested change
| Flightgear (Simulation) | | |
| JSBSim (Simulation) | | |
| jMAVSim (Simulation) | | |
| SIH (Simulation) | | |

| JSBSim (Simulation) | | |
| jMAVSim (Simulation) | | |
| SIH (Simulation) | | |
| Multivehicle Simulation | | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a feature of a simulation type as I understand it, so would be a sub set of gazebo (say).

| Multivehicle Simulation | | |
| [MAVLink (Communication)][MAVLink (Communication)] | | |

[uORB (Architecture)]: https://github.com/PX4/PX4-Autopilot/issues?q=label%3AUorb+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, I pulled all the links out to make this table editable. This works better with automatic prettiering.

| [Github Actions (Continuous Integration)][Github Actions (Continuous Integration)] | | |
| [Jenkins (Continuous Integration)][Jenkins (Continuous Integration)] | | |
| Linux (Toolchain) | | |
| Mac OS (Toolchain) | | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrpollo Are you populating the list of maintainers here?

| [Jenkins (Continuous Integration)][Jenkins (Continuous Integration)] | | |
| Linux (Toolchain) | | |
| Mac OS (Toolchain) | | |
| [Windows (Toolchain)][Windows (Toolchain)] | WSL2 | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windows toolchain is just WLS2 IMO. Cygwin and VMs are defunct or community supported. So I would remove the WSL2 subcomponent.

| RTK GPS (Driver) | Heading estimate from dual RTK GPS | [Alex Klimaj](https://github.com/AlexKlimaj) |
| [Documentation][Documentation] | PX4, MAVLink, QGC, MAVSDK | [Hamish Willee](https://github.com/hamishwillee) |
| Battery (Library) | | |
| Flight Task (Library) | | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Flight Task (Library) | | |
| Flight Task (Library) | | [Matthias Grob](https://github.com/MaEtUgR) |

Comment on lines +21 to +24
| [uORB (Architecture)][uORB (Architecture)] | | |
| [Parameter (Architecture)][Parameter (Architecture)] | | |
| Realtime Clock (Architecture) | | |
| Work queue (Architecture) | | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO all of these are subcomponets of "architecture", owned by either/both Beat and Daniel.

| Work queue (Architecture) | | |
| GNSS (State Estimation) | Velocity / Position | |
| | Heading | |
| [Optical flow (State Estimation)][Optical flow (State Estimation)] | | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a subset of estimation, not its own thing.

Copy link

No flaws found

@@ -9,3 +11,107 @@ A list of PX4 release notes, they contain a list of the changes that went into e
- [v1.12](../releases/1.12.md)

The full archive of releases for the PX4 autopilot project can be found on [GitHub](https://github.com/PX4/PX4-Autopilot/releases)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the rest of the maintainers are happy with this, so am I.

One concern is that there are no time-frames for expectations. Now I know we can't say to a maintainer, you will have tested and fixed all issues by next week, but we can say something like "the intent is that we'll converge within 2 months to a candidate in which only critical issues will be fixed, and 3 months for release from branch-off. Maintainers and tested are therefore expected to report on their progress to these goals" (or similar). Something that ties accountability.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've subedited and added some comments.

THe core components list needs another look - there are things like estimators etc that aren't mentioned that are pretty core. EKF!

UPshot, a bit broader at the component level, initially populated from your maintainer list.

Back to you @mrpollo

@hamishwillee
Copy link
Collaborator

@mrpollo FYI, still on you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants