mavlink: use command to set SiK ID #21082
Open
+224
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the param MAV_SIK_RADIO_ID and replaces it with a MAVLink command to set the radio's net ID. Using a command has the benefit that we get feedback whether the change has been accepted. The code now also reads back the bytes after doing the config in order to check for the radio's OK feedback. Previously, the commands were just sent blindly and there is the chance they did not actually get through. Signed-off-by: Julian Oes <[email protected]>
|
Doesn't it seem potentially problematic in lots of situations to be configuring your mavlink radio over mavlink? I believe there's a variation on the command you can do that makes the change on any remote radio as well. I have no objection to the command, but I would still keep a convenient local mechanism. How about either the questionable MAV_SIK_RADIO_ID or mavlink_main cli helper that uses the new command? |
amikhalev
reviewed
Feb 8, 2023
| switch (_parse_state) { | ||
| case OkParseState::None: | ||
| // Nothing to do. | ||
| break; |
There was a problem hiding this comment.
might as well break from the for loop here too, right?
|
I can try to |
Thanks, this on top of #20984 could be fine if it fits. |
However, this is now without the functionality to reset to factory default. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the param MAV_SIK_RADIO_ID and replaces it with a MAVLink command to set the radio's net ID.
Using a command has the benefit that we get feedback whether the change has been accepted. The code now also reads back the bytes after doing the config in order to check for the radio's OK feedback.
Previously, the commands were just sent blindly and there is the chance they did not actually get through.
This replaces #20984.
The command is pending to be included in MAVLink here:
mavlink/mavlink#1948
An example to trigger this from the ground implemented in MAVSDK:
mavlink/MAVSDK#1983