Improving visual QA + System-initiated notifications

[ovenmitt]

• Adding MRTK voice commands for simple system commands (next, previous step)
  

• Adding visual and task context to QA
  

• Overall UX improvements for the QA
  

• Merging angel_system with the latest version of the unity ARUI plugin
  

• ARUI shows notification and provides audio feedback when system detects a skip error
  

[Purg]

@ovenmitt For any binary files included here, do you think we could add those as git-LFS tracked items? I know there are some complexities around quotas and bandwidth limitations, so I'm not sure if you are aware of those for public github projects. It is ultimately the "right thing to do" with git to keep binaries files out of the git history. If we go this route, we will have to filter through commits to replace file contributions with GitLFS usage, or we could possible squash all of these changes into a single commit for simplification.

[ovenmitt]

@ovenmitt For any binary files included here, do you think we could add those as git-LFS tracked items? I know there are some complexities around quotas and bandwidth limitations, so I'm not sure if you are aware of those for public github projects. It is ultimately the "right thing to do" with git to keep binaries files out of the git history. If we go this route, we will have to filter through commits to replace file contributions with GitLFS usage, or we could possible squash all of these changes into a single commit for simplification.

I will remove the files, since they are not necessary for the ARUI to work at this point.

[Purg]

Hi @ovenmitt! I have a rebase of this branch onto latest master as well as a fix for the code style of the files causing that CI failure. Do you mind if I force-push that to here, or are you still working on anything regarding this topic branch?

[derkmed]

Oh this is soooo exciting!

[Purg]

This change in parameter name is going to break all of our other configurations. I would prefer that this parameter name not be changed, but you just assign the value to it as is appropriate for your local usage in your configuration file.

[ovenmitt]

Just updated it

[Purg]

I have a fix for what is causing the code-style CI to fail, but I can't seem to push it here, despite the Maintainers are allowed to edit this pull request. seeming to be enabled. The following diff patch file may be applied with git apply style-fix.txt

style-fix.txt

[Purg]

Can you run ./angel-workspace-shell.sh -- black . in your terminal, observe the changed and then commit those? That should be what is necessary to address the style issues. The items that I keep seeing crop up in this CI job are consistent with what that call fixes.