Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the annotation name to the onAnnotationsChanged payload when annotation is removed on iOS #309

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ios/RCTPSPDFKit/Converters/RCTConvert+PSPDFAnnotation.m
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ @implementation RCTConvert (PSPDFAnnotation)
[annotationsJSON addObject:annotationDictionary];
}
} else {
// We only generate Instant JSON data for attached annotations. When an annotation is deleted, we only set the annotation uuid.
[annotationsJSON addObject:uuidDict];
// We only generate Instant JSON data for attached annotations. When an annotation is deleted, we only set the annotation uuid and name.
[annotationsJSON addObject:@{@"uuid" : annotation.uuid, @"name" : annotation.name ?: [NSNull null]}];
}
}

Expand Down