Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the annotation name to the onAnnotationsChanged payload when annotation is removed on iOS #309

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Oct 15, 2019

This is the iOS implementation for #283


Details

This is the payload that we send on iOS for onAnnotationsChanged when an annotation is removed:

{
  change: 'removed',
  annotations: [
    {
      uuid: '2D28DCB5-002B-4B5A-843F-F142D618838F',
      name: '2D28DCB5-002B-4B5A-843F-F142D618838F',
    }
  ]
}

An this is the Android payload:

{
  change: 'removed',
  annotations: [
    {
      name: '2D28DCB5-002B-4B5A-843F-F142D618838F',
    }
  ]
}

Acceptance Criteria

@radazzouz radazzouz merged commit 1ff0220 into master Oct 16, 2019
@radazzouz radazzouz deleted the rad/add-annotation-name-to-payload-onAnnotationsChanged-when-removed branch October 16, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants