feat(submodule): add PMOVES-Spark-VSS and integration handoff - #2277
Merged
Merged
Conversation
- Add PMOVES-Spark-VSS submodule (POWERFULMOVES/PM-Spark-video-search-and-summarization), tracking main. - Add SUBMODULE_CODEX_HOMES overlay for the VSS submodule. - Add SPARK_VSS_INTEGRATION_2026-07-29.md handoff with foundation status, next-step plan for Claw skills, pmoves-vss-agent compose service, registry/catalog parity, and full-stack overlay risks. - Update SPARK_HF_MCP_SERVER_WIRING_2026-07-28.md to mark VSS lane claimed. - Update AGNOTE4482PHI.t1.md with #2276 merge release and new VSS claim.
github-actions
Bot
added
docs
Contributor
📝 WalkthroughWalkthroughAdds the PMOVES-Spark-VSS submodule and pins its revision, then adds documentation covering its integration blueprint, validation checks, handoff status, and planned agent/Claw wiring. ChangesSPARK VSS Integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f25dff132b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [submodule "PMOVES-Spark-VSS"] | ||
| path = PMOVES-Spark-VSS | ||
| url = https://github.com/POWERFULMOVES/PM-Spark-video-search-and-summarization.git | ||
| branch = main |
There was a problem hiding this comment.
When the documented local release checks run, make -C pmoves submodule-branch-policy-check rejects this new entry because pmoves/mk/preflight.mk permits main only for PMOVES-ClawZ; the resulting failure explicitly lists PMOVES-Spark-VSS -> main. Since the overlay says this fork intentionally has no hardened branch, add PMOVES-Spark-VSS=main to SUBMODULE_BRANCH_ALLOW rather than leaving the new submodule in permanent violation of the gate.
AGENTS.md reference: pmoves/AGENTS.md:L38-L39
Useful? React with 👍 / 👎.
Comment on lines
+365
to
+368
| [submodule "PMOVES-Spark-VSS"] | ||
| path = PMOVES-Spark-VSS | ||
| url = https://github.com/POWERFULMOVES/PM-Spark-video-search-and-summarization.git | ||
| branch = main |
There was a problem hiding this comment.
On the weekly schedule, and on manual runs with the submodule filter left blank, .github/workflows/submodule-update-check.yml only iterates the four hardcoded entries in TRACKED_SUBMODULES (lines 33-40). Because this new tracked submodule is absent from that list, its main gitlink will never receive the automated update checks or bump PRs; add its name:path:branch triple or derive the list directly from .gitmodules.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pmoves/docs/AGENTS/AGNOTE4482PHI.t1.md`:
- Line 1279: Add the required collision-avoidance TTL to the VSS CLAIM entry in
AGNOTE4482PHI, preserving its existing branch, scope, worktree, three-body, and
agent_signature details. Use the established claim format and a TTL value
consistent with the protocol.
In `@pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Spark-VSS.md`:
- Around line 32-34: Update the verification sections in
pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Spark-VSS.md lines 32-34 and
pmoves/docs/handoffs/SPARK_VSS_INTEGRATION_2026-07-29.md lines 107-109 to verify
the checked-out branch with git -C PMOVES-Spark-VSS branch --show-current, or
relabel the existing git submodule status command as revision/status
verification rather than branch verification.
In `@pmoves/docs/handoffs/SPARK_VSS_INTEGRATION_2026-07-29.md`:
- Around line 58-60: Resolve the planned host port in the handoff’s service
configuration by checking the canonical port registry/catalog rather than
assuming 8204 is available. Replace 8204 with a demonstrably free port outside
the occupied HF services range, and update all corresponding references,
including the later port allocation section, while preserving the internal port
8000.
- Around line 51-57: Correct the recommended Docker Compose build context in the
integration documentation so it resolves from pmoves/docker-compose.yml to the
repository-root submodule, rather than nesting PMOVES-Spark-VSS under pmoves.
Update the Build context value to the appropriate relative path, or explicitly
specify the Compose project directory while preserving the existing Dockerfile
location.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c29f1621-c591-4a0f-9b0a-7846e9651dd8
📒 Files selected for processing (6)
.gitmodulesPMOVES-Spark-VSSpmoves/docs/AGENTS/AGNOTE4482PHI.t1.mdpmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Spark-VSS.mdpmoves/docs/handoffs/SPARK_HF_MCP_SERVER_WIRING_2026-07-28.mdpmoves/docs/handoffs/SPARK_VSS_INTEGRATION_2026-07-29.md
|
|
||
| - `2026-07-29T02:17:00Z` RELEASE `KIMI-SPARK` scope: **PR #2276 merged to main** (admin-merge). Head `232cc91a6` lands hf-mcp-server compose wiring, real MCP transport, localhost bind, doc parity, and agent-teams registration. All required CI checks green; `triage` bot flaked on Claude Code Action init (infra, non-blocking). HF_TOKEN verified in local env via `with-env.sh` after bundle sync. Next lane: PM-Spark VSS submodule + pmoves-vss-agent compose service per handoff doc §Claw opportunity. agent_signature: `ACK::KIMI-SPARK::HF-MCP-MERGED-2026-07-29`. | ||
|
|
||
| - `2026-07-29T02:20:00Z` CLAIM `KIMI-SPARK` scope: **SPARK Video Search & Summarization (VSS) integration for Claw and agent mesh.** Submodule `PM-Spark-video-search-and-summarization` as `PMOVES-Spark-VSS/`, add `pmoves-vss-agent` compose service, register in agent_registry + agent-teams + CATALOG, install agentskills.io VSS skills into Claw skill directory, expose VSS orchestrator/analytics tools to PMOVES agents. Worktree: `/tmp/PMOVES.AI-spark-vss`. Branch: `feature/spark-vss-submodule-wiring`. Three-body: delivery=KIMI-SPARK, control=operator/DARKXSIDE (submodule + compose change), memory=this trail + `pmoves/docs/handoffs/SPARK_HF_MCP_SERVER_WIRING_2026-07-28.md` VSS section. agent_signature: `ACK::KIMI-SPARK::SPARK-VSS-CLAIM-2026-07-29`. |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Add the claim TTL.
The VSS CLAIM includes the branch and scope but omits the required TTL, so other agents cannot determine when the lane expires. Add a TTL consistent with the collision-avoidance protocol.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pmoves/docs/AGENTS/AGNOTE4482PHI.t1.md` at line 1279, Add the required
collision-avoidance TTL to the VSS CLAIM entry in AGNOTE4482PHI, preserving its
existing branch, scope, worktree, three-body, and agent_signature details. Use
the established claim format and a TTL value consistent with the protocol.
Source: Path instructions
Comment on lines
+32
to
+34
| ```bash | ||
| # Submodule present and on expected branch | ||
| git submodule status PMOVES-Spark-VSS |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use a command that actually verifies the tracked branch.
git submodule status verifies the gitlink revision and dirty state, but not that the checkout is on main.
pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Spark-VSS.md#L32-L34: addgit -C PMOVES-Spark-VSS branch --show-currentor relabel the check as revision/status verification.pmoves/docs/handoffs/SPARK_VSS_INTEGRATION_2026-07-29.md#L107-L109: apply the same correction to the verification section.
📍 Affects 2 files
pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Spark-VSS.md#L32-L34(this comment)pmoves/docs/handoffs/SPARK_VSS_INTEGRATION_2026-07-29.md#L107-L109
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Spark-VSS.md` around lines 32
- 34, Update the verification sections in
pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Spark-VSS.md lines 32-34 and
pmoves/docs/handoffs/SPARK_VSS_INTEGRATION_2026-07-29.md lines 107-109 to verify
the checked-out branch with git -C PMOVES-Spark-VSS branch --show-current, or
relabel the existing git submodule status command as revision/status
verification rather than branch verification.
Comment on lines
+51
to
+57
| Recommended first shape: | ||
|
|
||
| | Field | Value | | ||
| |-------|-------| | ||
| | Service name | `pmoves-vss-agent` | | ||
| | Build context | `PMOVES-Spark-VSS/services/agent/` | | ||
| | Dockerfile | `docker/Dockerfile` | |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Fix the compose build context path.
Because the existing compose file is pmoves/docker-compose.yml and the submodule is at repository root, PMOVES-Spark-VSS/services/agent/ resolves under pmoves/ and will not find the submodule. Use the path relative to the compose file, or explicitly configure the compose project directory.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pmoves/docs/handoffs/SPARK_VSS_INTEGRATION_2026-07-29.md` around lines 51 -
57, Correct the recommended Docker Compose build context in the integration
documentation so it resolves from pmoves/docker-compose.yml to the
repository-root submodule, rather than nesting PMOVES-Spark-VSS under pmoves.
Update the Build context value to the appropriate relative path, or explicitly
specify the Compose project directory while preserving the existing Dockerfile
location.
Comment on lines
+58
to
+60
| | Internal port | `8000` | | ||
| | Host port | `8204` (next free after hf-mcp-server `:8203`) | | ||
| | Profile | `agents`, `media` | |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Resolve the 8204 port allocation before implementation.
The handoff calls 8204 the next free port, but later states that 8200-8299 is already used by HF services. Check the canonical registry/catalog and select a demonstrably free port; otherwise the planned service may collide at startup.
Also applies to: 89-96
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pmoves/docs/handoffs/SPARK_VSS_INTEGRATION_2026-07-29.md` around lines 58 -
60, Resolve the planned host port in the handoff’s service configuration by
checking the canonical port registry/catalog rather than assuming 8204 is
available. Replace 8204 with a demonstrably free port outside the occupied HF
services range, and update all corresponding references, including the later
port allocation section, while preserving the internal port 8000.
Source: Coding guidelines
Closed
7 tasks
POWERFULMOVES
pushed a commit
that referenced
this pull request
Aug 18, 2026
…ed, stale VSS claim released Claims the active SPARK lanes under the operator's merge/fix split (4090 merges, Z890 tools, SPARK reviews + registers), and releases the stale feature/spark-vss-submodule-wiring claim after verifying it landed via squash #2277. Generated with Crush
POWERFULMOVES
pushed a commit
that referenced
this pull request
Aug 18, 2026
…ed, stale VSS claim released Claims the active SPARK lanes under the operator's merge/fix split (4090 merges, Z890 tools, SPARK reviews + registers), and releases the stale feature/spark-vss-submodule-wiring claim after verifying it landed via squash #2277. Generated with Crush
POWERFULMOVES
added a commit
that referenced
this pull request
Aug 18, 2026
…08-18) (#2596) * docs(agents): register the SPARK-KIMI convergence wave (2026-08-10 → 08-18) The claim register's last SPARK-KIMI entry was 2026-05-27; this session landed eight lanes that were never registered. One CLAIM+RELEASE entry registers them with live-main merge verification for each: - Hermes unblock chain (fork sync #3 + gitlink #2511) - P7 legacy stanza fix #2549 (+ pr-monitor bot classifier fix) - PMOVES-crush visual ecosystem (#10/#11 + promotion #2571) - pmoves-keygen adoption (fork #1 OPEN, parent #2591) — closes the pending-ml signing-card gap (24/25 cards h-only) - #2515 fleet handoffs docs - Hygiene: 86-commit stack proven landed and retired; 10 worktrees + 5 stashes cleared; cipher-mcp deletion corrected-to-restore - ~100GB disk recovery - P7 migrated to canonical service (13 rooms, NATS connected) Open follow-ups listed unclaimed for the next lane owners. 💘 Generated with Crush * docs(agnote): SPARK-KIMI lane refresh — coordination split acknowledged, stale VSS claim released Claims the active SPARK lanes under the operator's merge/fix split (4090 merges, Z890 tools, SPARK reviews + registers), and releases the stale feature/spark-vss-submodule-wiring claim after verifying it landed via squash #2277. Generated with Crush * docs(agnote): correct the Hermes commit count and the SPARK registration gap Two review findings on the register entry, both verified against source. Hermes fork-sync #3 advanced 42 upstream commits, not 49. The promotion commit f6c7936 corrects this in its own body ("42 commits advance on the hardened branch"); 49 was the original PR title. A provenance register that preserves a superseded count disagrees with the commit it summarizes. The "last SPARK-KIMI entry was 2026-05-27" claim was false. The same register already holds a SPARK-KIMI claim on 2026-06-01, a CLAIM/RELEASE pair on 2026-07-13, and KIMI-SPARK activity through 2026-07-29. The real unregistered interval is 2026-07-29 -> 2026-08-18. Overstating it by two months would have made lane reconciliation unreliable in exactly the direction that causes duplicate work. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Agent Zero <agent.zero@pmoves.ai> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lays the foundation for integrating the PMOVES/SPARK fork of the NVIDIA Video Search & Summarization (VSS) blueprint into the PMOVES agent mesh.
Changes
Out of scope (future PRs)
Verification
Related
Summary by CodeRabbit
New Features
Documentation