Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Token Update] Elevation semantic token update #209

Closed
6 of 10 tasks
julien-deramond opened this issue Oct 18, 2024 · 3 comments · Fixed by #228
Closed
6 of 10 tasks

[Token Update] Elevation semantic token update #209

julien-deramond opened this issue Oct 18, 2024 · 3 comments · Fixed by #228
Assignees
@pylapp
Labels
🧬 token Related to tokens (raws, semantics or components)

Comments

@julien-deramond
Copy link
Contributor

julien-deramond commented Oct 18, 2024 •
edited by pylapp
Loading

Type of tokens

  • Raw token (i.e. associated to SwiftUI or Swift value)
  • Semantic token (i.e. pointing to a raw token)
  • Component token (i.e. pointing to a semantic token, used for a component)

Description

Some elevation semantic tokens have been removed:

  • elevationBlurFocus
  • elevationXFocus
  • elevationYFocus
  • elevationColorFocus

It also means that you can drop the composite elevationFocus token, or any elevation*Focus tokens.

Motivation & Context

Types of change

  • Add new tokens
  • Update existing tokens (i.e. change name or value)
  • Remove existing token

Checklist for Core Team

  • Tokens have been updated
  • Documentations have been updated
  • Unit tests have been updated
  • Retrocompatibility has been checked, or broken API have been flagged as deprecated with a workaround
@julien-deramond julien-deramond added 🧬 token Related to tokens (raws, semantics or components) 🔍 triage A new issue that needs to be treated labels Oct 18, 2024
@julien-deramond julien-deramond added the 💥 blocking Issue can go further and is blocked by something label Oct 18, 2024
@julien-deramond
Copy link
Contributor Author

Put a "blocking" label on this one. Please wait until I sync something weird with the designers.

@julien-deramond
Copy link
Contributor Author

Issue unblocked, the description is updated regarding the "elevation-focus" token.

@julien-deramond julien-deramond removed the 💥 blocking Issue can go further and is blocked by something label Oct 21, 2024
@julien-deramond julien-deramond moved this from Triage to Todo in [OUDS] Project Oct 21, 2024
@julien-deramond julien-deramond moved this from Todo to Triage in [OUDS] Project Oct 21, 2024
@pylapp pylapp moved this from Triage to In Progress in [OUDS] Project Oct 21, 2024
pylapp added a commit that referenced this issue Oct 21, 2024
@pylapp
refactor: remove elevation focus semantic tokens (#209)
db63c06 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
Copy link
Member

pylapp commented Oct 21, 2024

@Tayebsed93 Pour l'issue #154 il faudra si besoin que tu prennes en compte que ces tokens ont été retirés

@pylapp pylapp linked a pull request Oct 21, 2024 that will close this issue
Remove elevation focus semantic tokens (#209) #228
Merged
pylapp added a commit that referenced this issue Oct 21, 2024
@pylapp
refactpr: rRemove elevation focus semantic tokens (#209) (#228)
199e1dd 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Oct 21, 2024
pylapp added a commit that referenced this issue Oct 21, 2024
@pylapp
refactor: remove elevation*Focus* semantic tokens (#209) (#228)
840586c 
Following tokens have been removed: `elevationBlurFocus`, `elevationXFocus`, `elevationYFocus`, `elevationColorFocus` and `elevationFocus`

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
pylapp added a commit that referenced this issue Oct 31, 2024
@pylapp @ludovic35 @boosted-bot
Release 0.5.0 (#269)
5ce9b68 
Release of version 0.5.0
See below the full CHANGELOG details.

Added:
- [DemoApp] App icons for debug, alpha, beta and production releases ([#140](#140))
- [Tool] GitHub Actions workflow for CI/CD ([#256](#256))
- [DemoApp] Add new tokens in size tokens page ([#245](#245))
- [Library] Semantic token `borderWidthFocusInset` (value of `borderWidth100`) ([#207](#207), [#241](#241))
- [Library] Semantic token `fontWeightCode` ([#242](#242))
- [DemoApp] Update space tokens screen with all categories ([#178](#178))

Changed:
- [Library] Update `ElevationSemanticTokens` (tokenator *20241031125053*)
- [Library] Update `OrangeBrandColorRawTokens` (tokenator *20241030132734*)
- [Library] Update `BorderSemanticTokens` (tokenator *20241025110844*)
- [Library] Rename color semantic tokens `colorBackground*` to `colorBg*`
- [Library] Rename `MultipleSpacingTokens` to `MultipleSpaceTokens` and `MultipleSizingTokens` to `MultipleSizeTokens`
- [Library] Extract composite semantic tokens from semantic tokens (`ElevationSemanticTokens`, `TypographySemanticTokens`)
- [Library] Improve documentation about the use of semantic tokens
- [Library] Update `OpacitySemanticTokens` (tokenator *20241025101305*)
- [Library] Rename `*Spacing*Tokens` and `*Sizing*Tokens` to `*Space*Tokens` and `*Size*Tokens` ([#237](#237))
- [Library] Update `ElevationRawTokens` (tokenator *20241022174330*)
- [Library] Update `DimensionRawTokens` (tokenator *20241022132646*)
- [Tool] Improve configuration of SwiftLint, update to v0.57.0 ([#77](#77))
- [Library] Rename all color semantic tokens `*OnBackground*` to `*OnBg*` ([#208](#208))
- [Library] Rename `colorDecorativeBrandTertiary` to `colorDecorativeTertiary`
- [Library] Rename `colorDecorativeBrandPrimary` to `colorDecorativePrimary` ([#208](#208))
- [Library] Rename `colorDecorativeSkinTint*` to `colorDecorativeSkinTint*`
- [Library] Rename `colorActionVisitedOnBackgroundEmphasized` to `colorActionVisitedOnBgEmphasized` ([#208](#208))
- [Library] Update color semantic tokens ([#208](#208))
- [Library] Update `BorderRawTokens` (tokenator *20241022102003*)
- [Library] Update `ColorRawTokens` (tokenator *20241021180411*)
- [Tool] Migration to Swift 6
- [Tool] Migration from *Xcode 15.3* to to *Xcode 16* ([#201](#201))
- [Library] Rename `borderWidthOutsideFocus` to `borderWidthFocus` ([#207](#207))
- [Library] Update `OpacityRawTokens` (tokenator *20241021134644*)

Removed:
- [Library] Semantic tokens `colorDecorativeBrandTertiaryMuted`, `colorDecorativeBrandTertiaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `colorDecorativeBrandSecondaryMuted`, `colorDecorativeBrandSecondaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `colorDecorativeBrandPrimaryMuted`, `colorDecorativeBrandPrimaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `elevationBlurFocus`, `elevationXFocus`, `elevationYFocus`, `elevationColorFocus` ([#209](#209))

Fixed:
- [DemoApp] Update typography screen to use right color on token name ([#213](#213))
- [DemoApp] Remove duplicated section in color page for content on background values ([#236](#236))
- [DemoApp] Hide from Voice Over decorative image in theme selector (a11y)

Security:
- [Tool] Move to Ruby 3.3.5 to fix Dependabot alert about *REXML ReDoS vulnerability* (CVE-2024-49761) ([#5](https://github.com/Orange-OpenSource/ouds-ios/security/dependabot/5))

Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: boosted-bot <[email protected]>
@pylapp pylapp removed the 🔍 triage A new issue that needs to be treated label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
🧬 token Related to tokens (raws, semantics or components)
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove elevation focus semantic tokens (#209) Orange-OpenSource/ouds-ios
4 participants
@pylapp @ludovic35 @julien-deramond @Tayebsed93