Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo App] Adjust spacing screen page #178

Closed
1 task done
ludovic35 opened this issue Oct 8, 2024 · 0 comments · Fixed by #238
Closed
1 task done

[Demo App] Adjust spacing screen page #178

ludovic35 opened this issue Oct 8, 2024 · 0 comments · Fixed by #238
Assignees
@ludovic35
Labels
📱 demo app Update of the Demo App

Comments

@ludovic35
Copy link
Member

ludovic35 commented Oct 8, 2024 •
edited
Loading

Prerequisites

As a

a user of the design system for mobile

... I want to

see the Spacing (dimension1/2) token

... so that I can

approuve the usage of tokens

Motivation and context

Q1. Do we need to manage spacing for verticalSizeClass.
Q2. Do we need to illustrate all spacings (fixed, gap, ...)

Evol 1. When color token if fully available, update the color of the spacing illustration

Proposed Solution

No response

Other

No response

Contact Details

No response
@ludovic35 ludovic35 added the 🔍 triage A new issue that needs to be treated label Oct 8, 2024
@ludovic35 ludovic35 mentioned this issue Oct 8, 2024
Closed
1 task
@ludovic35 ludovic35 added the 📱 demo app Update of the Demo App label Oct 8, 2024
@pylapp pylapp assigned ludovic35 and unassigned pylapp, ludovic35 and Tayebsed93 Oct 9, 2024
@ludovic35 ludovic35 removed the 🔍 triage A new issue that needs to be treated label Oct 14, 2024
@pylapp pylapp changed the title [DemoApp]: Adjust spacing screen page [DemoApp] Adjust spacing screen page Oct 14, 2024
@pylapp pylapp changed the title [DemoApp] Adjust spacing screen page [Demo App] Adjust spacing screen page Oct 14, 2024
@ludovic35 ludovic35 linked a pull request Oct 23, 2024 that will close this issue
[#178] Update space tokens screen with all categories #238
Merged
13 tasks
@pylapp pylapp moved this from Triage to In Progress in [OUDS] Project Oct 24, 2024
pylapp pushed a commit that referenced this issue Oct 24, 2024
@ludovic35
feat: adjust space tokens screen with all categories (#178) (#238)
8341401 
Closes #178 

Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Oct 24, 2024
pylapp added a commit that referenced this issue Oct 31, 2024
@pylapp @ludovic35 @boosted-bot
Release 0.5.0 (#269)
5ce9b68 
Release of version 0.5.0
See below the full CHANGELOG details.

Added:
- [DemoApp] App icons for debug, alpha, beta and production releases ([#140](#140))
- [Tool] GitHub Actions workflow for CI/CD ([#256](#256))
- [DemoApp] Add new tokens in size tokens page ([#245](#245))
- [Library] Semantic token `borderWidthFocusInset` (value of `borderWidth100`) ([#207](#207), [#241](#241))
- [Library] Semantic token `fontWeightCode` ([#242](#242))
- [DemoApp] Update space tokens screen with all categories ([#178](#178))

Changed:
- [Library] Update `ElevationSemanticTokens` (tokenator *20241031125053*)
- [Library] Update `OrangeBrandColorRawTokens` (tokenator *20241030132734*)
- [Library] Update `BorderSemanticTokens` (tokenator *20241025110844*)
- [Library] Rename color semantic tokens `colorBackground*` to `colorBg*`
- [Library] Rename `MultipleSpacingTokens` to `MultipleSpaceTokens` and `MultipleSizingTokens` to `MultipleSizeTokens`
- [Library] Extract composite semantic tokens from semantic tokens (`ElevationSemanticTokens`, `TypographySemanticTokens`)
- [Library] Improve documentation about the use of semantic tokens
- [Library] Update `OpacitySemanticTokens` (tokenator *20241025101305*)
- [Library] Rename `*Spacing*Tokens` and `*Sizing*Tokens` to `*Space*Tokens` and `*Size*Tokens` ([#237](#237))
- [Library] Update `ElevationRawTokens` (tokenator *20241022174330*)
- [Library] Update `DimensionRawTokens` (tokenator *20241022132646*)
- [Tool] Improve configuration of SwiftLint, update to v0.57.0 ([#77](#77))
- [Library] Rename all color semantic tokens `*OnBackground*` to `*OnBg*` ([#208](#208))
- [Library] Rename `colorDecorativeBrandTertiary` to `colorDecorativeTertiary`
- [Library] Rename `colorDecorativeBrandPrimary` to `colorDecorativePrimary` ([#208](#208))
- [Library] Rename `colorDecorativeSkinTint*` to `colorDecorativeSkinTint*`
- [Library] Rename `colorActionVisitedOnBackgroundEmphasized` to `colorActionVisitedOnBgEmphasized` ([#208](#208))
- [Library] Update color semantic tokens ([#208](#208))
- [Library] Update `BorderRawTokens` (tokenator *20241022102003*)
- [Library] Update `ColorRawTokens` (tokenator *20241021180411*)
- [Tool] Migration to Swift 6
- [Tool] Migration from *Xcode 15.3* to to *Xcode 16* ([#201](#201))
- [Library] Rename `borderWidthOutsideFocus` to `borderWidthFocus` ([#207](#207))
- [Library] Update `OpacityRawTokens` (tokenator *20241021134644*)

Removed:
- [Library] Semantic tokens `colorDecorativeBrandTertiaryMuted`, `colorDecorativeBrandTertiaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `colorDecorativeBrandSecondaryMuted`, `colorDecorativeBrandSecondaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `colorDecorativeBrandPrimaryMuted`, `colorDecorativeBrandPrimaryEmphasized` ([#208](#208))
- [Library] Semantic tokens `elevationBlurFocus`, `elevationXFocus`, `elevationYFocus`, `elevationColorFocus` ([#209](#209))

Fixed:
- [DemoApp] Update typography screen to use right color on token name ([#213](#213))
- [DemoApp] Remove duplicated section in color page for content on background values ([#236](#236))
- [DemoApp] Hide from Voice Over decorative image in theme selector (a11y)

Security:
- [Tool] Move to Ruby 3.3.5 to fix Dependabot alert about *REXML ReDoS vulnerability* (CVE-2024-49761) ([#5](https://github.com/Orange-OpenSource/ouds-ios/security/dependabot/5))

Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: boosted-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludovic35 ludovic35

Labels
📱 demo app Update of the Demo App
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#178] Update space tokens screen with all categories Orange-OpenSource/ouds-ios
3 participants
@pylapp @ludovic35 @Tayebsed93