Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageEffect Animation 2.0 #879

Merged

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Jun 19, 2023

2nd iteration of #836 (also fixed 2 bugs in previous iteration)
moved the animation system to it's own separate AnimatePanel.tscn

Added:

  • It is now possible to preview other frames as well, not just the current frame

Changed:

  • Made the animate system more intuitive
  • Property animation now uses SceneTreeTween instead of Lerp which allows us to set:
    • Transition type and Ease mode
  • Animation starts from left of timeline and ends at right (in old system animation just went through whatever order cels were placed in selected cel array)

Fixed:

  • [0.11.0 and earlier issue] fixed issue when changing affect mode to something else and the back to Selected cels made the animate system appear even if no animatable properties were set for that image effect
  • [0.11.0 and earlier issue] fixed value and saturation sliders being divided by 360 (when they should be divided by 100). this bug was introduced in Animate image effect properties #836 (sorry about that)

Visuals:

here's animating an outline from 10 to 20 in old system

test-.6.mp4

here's doing the same thing in the new system

test-.7.mp4

@Variable-ind Variable-ind changed the title Better Image effect animation menu ImageEffect Animation 2.0 Jun 21, 2023
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, excellent work. Thank you!

@OverloadedOrama OverloadedOrama merged commit ae56cae into Orama-Interactive:master Jun 30, 2023
@Variable-ind Variable-ind deleted the Better-animation-menu branch July 10, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants