test(app,step-generation): also fix QT tests to use flow_rate in Python codegen#18396
Merged
test(app,step-generation): also fix QT tests to use flow_rate in Python codegen#18396
flow_rate in Python codegen#18396Conversation
59a7fb7 to
34d6625
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18396 +/- ##
===========================================
- Coverage 58.09% 25.79% -32.30%
===========================================
Files 3241 3247 +6
Lines 275356 275725 +369
Branches 32258 32185 -73
===========================================
- Hits 159977 71133 -88844
- Misses 115186 204565 +89379
+ Partials 193 27 -166
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR #18391 updated step-generation to use the new Python
flow_rateargument inaspirate()anddispense(). QT also has tests for Python code generation, but for some reason, the failures in the QT tests didn't show up until after I merged that PR.This updates the QT tests as well.
Test Plan and Hands on Testing
Ran the tests again.
It looks like
app/src/organisms/Desktop/Devices/RobotSettings/AdvancedTab/AdvancedTabSlideouts/__tests__/DeviceResetSlideout.test.tsxis still failing at HEAD, but I really don't think that's related to step-generation at all.Risk assessment
Low, hopefully.