Skip to content

test(app,step-generation): also fix QT tests to use flow_rate in Python codegen#18396

Merged
ddcc4 merged 1 commit intoedgefrom
dc-qtpy-appflowrate
May 19, 2025
Merged

test(app,step-generation): also fix QT tests to use flow_rate in Python codegen#18396
ddcc4 merged 1 commit intoedgefrom
dc-qtpy-appflowrate

Conversation

@ddcc4
Copy link
Copy Markdown
Contributor

@ddcc4 ddcc4 commented May 19, 2025

Overview

PR #18391 updated step-generation to use the new Python flow_rate argument in aspirate() and dispense(). QT also has tests for Python code generation, but for some reason, the failures in the QT tests didn't show up until after I merged that PR.

This updates the QT tests as well.

Test Plan and Hands on Testing

Ran the tests again.

It looks like app/src/organisms/Desktop/Devices/RobotSettings/AdvancedTab/AdvancedTabSlideouts/__tests__/DeviceResetSlideout.test.tsx is still failing at HEAD, but I really don't think that's related to step-generation at all.

Risk assessment

Low, hopefully.

@ddcc4 ddcc4 requested review from ahiuchingau and jerader May 19, 2025 21:17
@ddcc4 ddcc4 requested a review from a team as a code owner May 19, 2025 21:17
@ddcc4 ddcc4 force-pushed the dc-qtpy-appflowrate branch from 59a7fb7 to 34d6625 Compare May 19, 2025 21:51
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.79%. Comparing base (31037e7) to head (34d6625).
Report is 3 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18396       +/-   ##
===========================================
- Coverage   58.09%   25.79%   -32.30%     
===========================================
  Files        3241     3247        +6     
  Lines      275356   275725      +369     
  Branches    32258    32185       -73     
===========================================
- Hits       159977    71133    -88844     
- Misses     115186   204565    +89379     
+ Partials      193       27      -166     
Flag Coverage Δ
app 2.23% <ø> (-45.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1637 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ddcc4 ddcc4 merged commit fc29d04 into edge May 19, 2025
31 of 32 checks passed
@ddcc4 ddcc4 deleted the dc-qtpy-appflowrate branch May 19, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants