feat(step-generation): use new flow_rate argument for aspirate() and dispense()#18391
Merged
feat(step-generation): use new flow_rate argument for aspirate() and dispense()#18391
flow_rate argument for aspirate() and dispense()#18391Conversation
…and `dispense()`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18391 +/- ##
==========================================
+ Coverage 58.04% 58.12% +0.07%
==========================================
Files 3241 3241
Lines 275215 275297 +82
Branches 32211 32315 +104
==========================================
+ Hits 159761 160024 +263
+ Misses 115261 115080 -181
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ddcc4
added a commit
that referenced
this pull request
May 19, 2025
…thon codegen (#18396) # Overview PR #18391 updated step-generation to use the new Python `flow_rate` argument in `aspirate()` and `dispense()`. QT also has tests for Python code generation, but for some reason, the failures in the QT tests didn't show up until after I merged that PR. This updates the QT tests as well. ## Test Plan and Hands on Testing Ran the tests again. It looks like `app/src/organisms/Desktop/Devices/RobotSettings/AdvancedTab/AdvancedTabSlideouts/__tests__/DeviceResetSlideout.test.tsx` is still failing at HEAD, but I really don't think that's related to step-generation at all. ## Risk assessment Low, hopefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We added the
flow_rateargument toaspirate()anddispense()(AUTH-1627, PR #18326), so now in PD Python generation, we can just set the flow rate directly, instead of the hacky ratio we were emitting before.This makes the generated code much cleaner and easier to read.
Test Plan and Hands on Testing
Updated unit tests.
Examined generated code by hand.
I also re-exported Python for a test protocol and confirmed that it passes
analyze.Risk assessment
Low.