fix(analyses-snapshot-testing): heal rqa-4181 snapshots#18344
Closed
github-actions[bot] wants to merge 3 commits intoedgefrom
Closed
fix(analyses-snapshot-testing): heal rqa-4181 snapshots#18344github-actions[bot] wants to merge 3 commits intoedgefrom
github-actions[bot] wants to merge 3 commits intoedgefrom
Conversation
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was requested on the PR #18337