Conversation
sfoster1
added
the
gen-analyses-snapshot-pr
Contributor
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18342 |
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181
sfoster1
added
gen-analyses-snapshot-pr
Contributor
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18343 |
This PR was requested on the PR #18337 Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
Contributor
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18344 |
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com>
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 22, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 23, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works. Closes RQA-4181 ## testing - [x] put this on a robot - [x] upload a protocol that is pre-2.14 - [x] pre-protocol should still show the labware --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sfoster1 <3091648+sfoster1@users.noreply.github.com> (cherry picked from commit df9ee0d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not generating location sequences for the fake PE commands we generate for the pre-2.14 pre-protocol-engine protocols, and since the app is expecting them it wouldn't show any labware. Now we generate them, because the comment about how it would be hard is just wrong (?) and everything works.
Closes RQA-4181
testing