feat(step-generation): emit Python for airGapInPlace CommandCreator#18314
Merged
feat(step-generation): emit Python for airGapInPlace CommandCreator#18314
airGapInPlace CommandCreator#18314Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18314 +/- ##
=======================================
Coverage 24.68% 24.68%
=======================================
Files 3220 3220
Lines 272814 272820 +6
Branches 26000 25999 -1
=======================================
+ Hits 67335 67342 +7
+ Misses 205454 205453 -1
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jerader
approved these changes
May 12, 2025
Collaborator
jerader
left a comment
There was a problem hiding this comment.
woo! excited that we are able to wire this up now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
After the recent PAPI changes to support
air_gap()in-place, we can now generate Python for theairGapInPlaceCommandCreator.This in turn completes the support for the
airGapInTrashandairGapInWasteChutecompound commands.Note that in the
airGapInTrashandairGapInWasteChuteCommandCreators, we suppress the Python forprepareToAspirate, because the Pythonair_gap()command automatically issuesprepare_to_aspirate()(PR #17919).Test Plan and Hands on Testing
Added unit tests.
I also tried PD Python export for a protocol that used air gaps, and confirmed that it passed analysis.
Risk assessment
Low.