Skip to content

feat(step-generation): emit Python for airGapInPlace CommandCreator#18314

Merged
ddcc4 merged 2 commits intoedgefrom
dc-pdpy-airgap
May 12, 2025
Merged

feat(step-generation): emit Python for airGapInPlace CommandCreator#18314
ddcc4 merged 2 commits intoedgefrom
dc-pdpy-airgap

Conversation

@ddcc4
Copy link
Copy Markdown
Contributor

@ddcc4 ddcc4 commented May 9, 2025

Overview

After the recent PAPI changes to support air_gap() in-place, we can now generate Python for the airGapInPlace CommandCreator.

This in turn completes the support for the airGapInTrash and airGapInWasteChute compound commands.

Note that in the airGapInTrash and airGapInWasteChute CommandCreators, we suppress the Python for prepareToAspirate, because the Python air_gap() command automatically issues prepare_to_aspirate() (PR #17919).

Test Plan and Hands on Testing

Added unit tests.

I also tried PD Python export for a protocol that used air gaps, and confirmed that it passed analysis.

Risk assessment

Low.

@ddcc4 ddcc4 requested a review from jerader May 9, 2025 21:57
@ddcc4 ddcc4 requested a review from a team as a code owner May 9, 2025 21:57
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.68%. Comparing base (a19be0a) to head (0b209ef).
Report is 7 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18314   +/-   ##
=======================================
  Coverage   24.68%   24.68%           
=======================================
  Files        3220     3220           
  Lines      272814   272820    +6     
  Branches    26000    25999    -1     
=======================================
+ Hits        67335    67342    +7     
+ Misses     205454   205453    -1     
  Partials       25       25           
Flag Coverage Δ
protocol-designer 18.98% <0.00%> (-0.01%) ⬇️
step-generation 4.58% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ration/src/commandCreators/atomic/airGapInPlace.ts 82.50% <100.00%> (+6.02%) ⬆️
...tion/src/commandCreators/compound/airGapInTrash.ts 96.66% <100.00%> (ø)
...src/commandCreators/compound/airGapInWasteChute.ts 93.54% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo! excited that we are able to wire this up now.

@ddcc4 ddcc4 merged commit dd407aa into edge May 12, 2025
18 checks passed
@ddcc4 ddcc4 deleted the dc-pdpy-airgap branch May 12, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants