-
Notifications
You must be signed in to change notification settings - Fork 199
feat(api): add the touch_tip(mm_from_edge=...) argument to PAPI #17874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+66
−2
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f8edb42
Support touch_tip(mm_from_edge) argument.
ddcc4 8c37e1f
Fix lint
ddcc4 019a705
Add version check for mm_from_edge.
ddcc4 3dcf358
Merge remote-tracking branch 'origin' into mm_from_edge
ddcc4 bc1097e
Disable `C901 is too complex` lint error.
ddcc4 0996336
This won't be available until API 2.24. And need to hide argument fro…
ddcc4 0d7d3d3
Merge remote-tracking branch 'origin' into mm_from_edge
ddcc4 ba9392d
Use `None` instead of `0` as the default for `mm_from_edge`.
ddcc4 568c47f
Use `_Unset()` instead of `None` for default arg value.
ddcc4 437836f
Merge remote-tracking branch 'origin' into mm_from_edge
ddcc4 f051ae2
Lint
ddcc4 c8cb926
More lint
ddcc4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice documentation! No notes. Unless you want your single line breaks to be paragraph breaks, in which case you need to make them double line breaks.
We should also add this to the bottom of the docstring:
(I presume this is 2.24, since this PR is targeted on
edgeand 2.23 changes are going intochore_release-8.4.0)