Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differential Testing for Merkle.rs #524

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Differential Testing for Merkle.rs #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e96059
add first differential test for merkle.rs
Haxry Feb 5, 2025
861b0f3
Merge branch 'OpenZeppelin:main' into merkle-tests
Haxry Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/crypto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ num-traits.workspace = true
zeroize.workspace = true
educe.workspace = true
hex-literal.workspace = true
ethers-core = "1.0.2"
merkle-tree-rs = "0.1.0"

[dev-dependencies]
rand.workspace = true
Expand Down
34 changes: 34 additions & 0 deletions lib/crypto/src/merkle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,9 @@ impl core::fmt::Display for MultiProofError {
mod tests {
//! NOTE: The values used as input for these tests were all generated using
//! <https://github.com/OpenZeppelin/merkle-tree>.
use ethers_core::types::Bytes;
use hex_literal::hex;
use merkle_tree_rs::core::process_proof;
use rand::{thread_rng, RngCore};

use super::{Bytes32, KeccakBuilder, Verifier};
Expand Down Expand Up @@ -661,4 +663,36 @@ mod tests {
);
assert!(verification.is_err());
}

#[test]
fn test_differential_verifies_valid_proof() {
bytes! {
root = "9012f1e18a87790d2e01faace75aaaca38e53df437cdce2c0552464dda4af49c";
leaf = "0b42b6393c1f53060fe3ddbfcd7aadcca894465a5a438f69c87d790b2299b9b2";
}
let proof = bytes_array! {
"f1918e8562236eb17adc8502332f4c9c82bc14e19bfc0aa10ab674ff75b3d2f3",
"805b21d846b189efaeb0377d6bb0d201b3872a363e607c25088f025b0c6ae1f8",
"f0b49bb4b0d9396e0315755ceafaa280707b32e75e6c9053f5cdf2679dcd5c6a",
};

let leaf_bytes = Bytes::from(leaf);
let proof_vec: Vec<Bytes> =
proof.iter().map(|&p| Bytes::from(p)).collect();

let rebuilt_root_bytes = process_proof(leaf_bytes.clone(), &proof_vec);

let rebuilt_root: [u8; 32] = rebuilt_root_bytes
.as_ref()
.try_into()
.expect("Rebuilt root must be 32 bytes");

let verification = Verifier::verify(&proof, root, leaf);

assert_eq!(
rebuilt_root, root,
"Rebuilt root does not match expected root"
);
assert!(verification, "Verifier::verify returned false");
}
}