Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differential Testing for Merkle.rs #524

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Differential Testing for Merkle.rs #524

wants to merge 2 commits into from

Conversation

Haxry
Copy link

@Haxry Haxry commented Feb 5, 2025

Resolves #502

PR Checklist

  • Tests
  • Documentation
  • Changelog

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 861b0f3
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67a35f709be3d00008ded20d

@Haxry Haxry marked this pull request as draft February 5, 2025 12:55
@Haxry
Copy link
Author

Haxry commented Feb 5, 2025 •
edited
Loading

@0xNeshi i have added one differential test .
I have used merkle-tree-rs instead of rs-merkle because rs-merkle only supports sha256 and sha384, to use it for testing i have to implement shabuilder just like keccakbuilder.

Please let me know for any changes required !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidzyyys bidzyyys Awaiting requested review from bidzyyys bidzyyys is a code owner

@qalisander qalisander Awaiting requested review from qalisander qalisander is a code owner

@0xNeshi 0xNeshi Awaiting requested review from 0xNeshi 0xNeshi is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Differential Tests for Functions in _merkle.rs_
1 participant
@Haxry