Skip to content

Conversation

@Amxx
Copy link
Collaborator

@Amxx Amxx commented Oct 9, 2025

Produced by:

npm run compile
./scripts/minimize-pragma.js artifacts/build-info/*.json

(maybe we should have a bot that runs that periodically, or an action that we can trigger manually)

@Amxx Amxx requested a review from ernestognw October 9, 2025 18:17
@Amxx Amxx requested a review from a team as a code owner October 9, 2025 18:17
@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025

⚠️ No Changeset found

Latest commit: 18fe422

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx added this to the 5.5-final milestone Oct 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Walkthrough

Compiler pragma versions were adjusted in two Solidity contracts. In contracts/crosschain/ERC7786Recipient.sol, the pragma changed from ^0.8.27 to ^0.8.20 without modifying imports or runtime logic. In contracts/utils/RLP.sol, the pragma changed from ^0.8.27 to ^0.8.26, with no changes to imports, control flow, error handling, or public/exported declarations. No other files were modified.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the main change of updating Solidity pragma versions without unnecessary detail, clearly reflecting the purpose of the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description clearly states that the changes were produced by running the compile and minimize-pragma scripts, directly reflecting the pragma updates in the commit and relating to the presented changes. It ties to the modifications in compiler pragmas and even suggests automating the process, confirming it is on-topic and relevant to the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx Amxx merged commit d9f966f into OpenZeppelin:master Oct 9, 2025
25 checks passed
@Amxx Amxx deleted the chore/minimize-pragma branch October 9, 2025 19:10
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party but LGTM. Thanks!

Amxx added a commit that referenced this pull request Oct 9, 2025
Signed-off-by: Hadrien Croubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants