ref: added functionality to escapeJSONstrings (ref: #5251) #5508
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Is my approach correct , am i working right on this pr @Amxx ? |
Amxx
reviewed
Feb 14, 2025
Amxx
reviewed
Feb 14, 2025
|
|
||
| function _escapeJsonString(string memory input) private pure returns (string memory) { | ||
| bytes memory buffer = bytes(input); | ||
| bytes memory output = new bytes(buffer.length * 2); // Allocate max possible space |
There was a problem hiding this comment.
I'm worried this allocated a lot of memory that is not freed. This is quite expensive. Alternatives are:
- count number of "extra chars" in a loop, and allocate the right size directly
- resize the output buffer without a copy, and move the free memory ptr, using assembly
Amxx
reviewed
Feb 14, 2025
Amxx
reviewed
Feb 14, 2025
Co-authored-by: Hadrien Croubois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5251
A function to escape special characters in JSON strings
Handles key characters like quotes ("), backslashes (), forward slashes (/), and control characters (\n, \t, \r, etc.)
Prevents JSON injection attacks in NFT metadata and other use cases
PR Checklist
npx changeset add)