Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat code-size warnings as errors #5101

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Jul 1, 2024

Follow up to #5099.

The current config is treating code size as a warning (true is equivalent to 'warn'), which would not cause CI to fail. This config removes the line so that it's considered an error (according to default: 'error' below).

Feel free to close this if it's not the desired behavior.

Copy link

changeset-bot bot commented Jul 1, 2024

⚠️ No Changeset found

Latest commit: 3a22786

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx added this to the 5.3 milestone Oct 23, 2024
@Amxx
Copy link
Collaborator

Amxx commented Feb 13, 2025

I'd say this is desirable, unless it triggers when compiling the "coverage" contract that are way bigger (because of the added events).

CI shows that it should be ok, so I'd be in favor of it. We can revert back if it turns out its causing unforseen issues.

@Amxx Amxx requested review from arr00 and ernestognw February 13, 2025 16:36
@arr00 arr00 merged commit fa8bed6 into OpenZeppelin:master Feb 13, 2025
17 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Feb 14, 2025
Co-authored-by: Hadrien Croubois <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants