Move implementation fact to an API method #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
May 27, 2025
Contributor
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Nit: I like using the imperative mood for the subject line. See https://cbea.ms/git-commit/#imperative for the rationale.
This will allow various plugins to access this information more easily if needed.
binford2k
force-pushed
the
add_implementation_api
branch
from
5e6960a to
9d857ed
Compare
binford2k
changed the title
nmburgan
approved these changes
May 28, 2025
bastelfreak
added a commit
that referenced
this pull request
Jun 4, 2025
In OpenVoxProject/openvox-agent#66 someone reported issues during `puppet lookup` with the changes from #63 or #78. It's also easy to reproduce it locally: ``` root@:~# puppet lookup puppet::puppetmaster Warning: The node parameter 'implementation' for node 'mirror.voxpupu.li' was already set to 'openvox'. It could not be set to 'openvox' --- voxpupu.li root@:~# echo $? 0 root@:~# ```
bastelfreak
added a commit
that referenced
this pull request
Jun 4, 2025
In OpenVoxProject/openvox-agent#66 someone reported issues during `puppet lookup` with the changes from #63 or #78. It's also easy to reproduce it locally: ``` root@:~# puppet lookup puppet::puppetmaster Warning: The node parameter 'implementation' for node 'mirror.voxpupu.li' was already set to 'openvox'. It could not be set to 'openvox' --- voxpupu.li root@:~# echo $? 0 root@:~# ```
nmburgan
added a commit
that referenced
this pull request
Sep 5, 2025
puppet-runtime: Update 202505151->202507081
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow various plugins to access this information more easily
if needed.