Add implementation fact to agent and server.
#63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The testing for the server_facts is..."limited". Looks like there are only a bunch of tests in the unit[sic!] tests for the compiler terminus. (These look more like integration tests of the second degree.) |
added 2 commits
May 23, 2025 21:19
As specified in OpenVoxProject/planning#39, the agent will now make its implementation flavor known to the compiler through a built-in fact, as will the server (through a server fact).
ffrank
force-pushed
the
planning-39-impl-facts
branch
from
20be7df to
ae363fc
Compare
bastelfreak
approved these changes
May 23, 2025
tuxmea
approved these changes
May 23, 2025
smortex
changed the title
implementation fact to agent and server.
|
GitHub Actions is not permitted to create or approve pull requests. |
bastelfreak
added a commit
that referenced
this pull request
Jun 4, 2025
In OpenVoxProject/openvox-agent#66 someone reported issues during `puppet lookup` with the changes from #63 or #78. It's also easy to reproduce it locally: ``` root@:~# puppet lookup puppet::puppetmaster Warning: The node parameter 'implementation' for node 'mirror.voxpupu.li' was already set to 'openvox'. It could not be set to 'openvox' --- voxpupu.li root@:~# echo $? 0 root@:~# ```
bastelfreak
added a commit
that referenced
this pull request
Jun 4, 2025
In OpenVoxProject/openvox-agent#66 someone reported issues during `puppet lookup` with the changes from #63 or #78. It's also easy to reproduce it locally: ``` root@:~# puppet lookup puppet::puppetmaster Warning: The node parameter 'implementation' for node 'mirror.voxpupu.li' was already set to 'openvox'. It could not be set to 'openvox' --- voxpupu.li root@:~# echo $? 0 root@:~# ```
nmburgan
pushed a commit
that referenced
this pull request
Sep 5, 2025
CI: Complete all acceptance tests
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in OpenVoxProject/planning#39, the agent will now make its implementation flavor known to the compiler through a built-in fact, as will the server (through a server fact).