Skip to content

fix: whitelist marisa-trie in central license check - #65

Merged
JarbasAl merged 1 commit into
devfrom
fix/license-whitelist-marisa-trie
Jul 4, 2026
Merged

fix: whitelist marisa-trie in central license check#65
JarbasAl merged 1 commit into
devfrom
fix/license-whitelist-marisa-trie

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 4, 2026

Copy link
Copy Markdown
Member

marisa-trie is dual-licensed MIT AND (BSD-2-Clause OR LGPL-2.1-or-later). The license checker flags the whole expression as WeakCopyleft because of the LGPL-2.1-or-later option, but the license grants an explicit BSD-2-Clause OR LGPL choice — we elect the permissive BSD-2-Clause. It is pulled transitively via langcodes/language_data across many OVOS repos and used as an unmodified imported trie library.

Adds it to the central whitelist (workflow inline regex + docs/license-whitelist.md), alongside tqdm. Unblocks license-check on ovos-persona#192 and any other repo resolving language data.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Updated the license whitelist notes to include marisa-trie as an approved package, with justification for its compatible license status.
    • Refreshed the example regex pattern to reflect the expanded whitelist.
  • Chores

    • Updated the license-check workflow so marisa-trie is treated the same as other already-allowed license-flagged packages.

marisa-trie is MIT AND (BSD-2-Clause OR LGPL-2.1-or-later); the checker
flags the LGPL option as WeakCopyleft, but the license grants an explicit
BSD-2-Clause choice. Used as an unmodified imported trie library, pulled
transitively via langcodes/language_data across many OVOS repos.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f45c209-08b3-4677-8110-98e9952a8cbe

📥 Commits

Reviewing files that changed from the base of the PR and between 436a1cf and add10e3.

📒 Files selected for processing (2)
  • .github/workflows/license-check.yml
  • docs/license-whitelist.md

📝 Walkthrough

Walkthrough

This PR adds marisa-trie as an allowlisted package for license checks. It expands the central exclude regex in the license-check GitHub workflow and updates the license-whitelist documentation table and regex form to include the new entry with a compatibility justification.

Changes

License whitelist update

Layer / File(s) Summary
Workflow exclude regex expansion
.github/workflows/license-check.yml
Adds an anchored marisa-trie alternation to the central allowlisted regex used to build the license-check exclude pattern, alongside the existing tqdm branch.
Whitelist documentation update
docs/license-whitelist.md
Adds a new table row for marisa-trie with its license expression, flagged category, and justification, and extends the regex form exclude pattern to include marisa-trie.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/license-whitelist-marisa-trie

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl
JarbasAl marked this pull request as ready for review July 4, 2026 04:54
@JarbasAl
JarbasAl merged commit 02b4bf4 into dev Jul 4, 2026
1 check passed
@JarbasAl
JarbasAl deleted the fix/license-whitelist-marisa-trie branch July 4, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant