fix: whitelist marisa-trie in central license check - #65
Merged
Conversation
marisa-trie is MIT AND (BSD-2-Clause OR LGPL-2.1-or-later); the checker flags the LGPL option as WeakCopyleft, but the license grants an explicit BSD-2-Clause choice. Used as an unmodified imported trie library, pulled transitively via langcodes/language_data across many OVOS repos. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds ChangesLicense whitelist update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
marisa-trie is dual-licensed
MIT AND (BSD-2-Clause OR LGPL-2.1-or-later). The license checker flags the whole expression as WeakCopyleft because of the LGPL-2.1-or-later option, but the license grants an explicitBSD-2-Clause OR LGPLchoice — we elect the permissive BSD-2-Clause. It is pulled transitively vialangcodes/language_dataacross many OVOS repos and used as an unmodified imported trie library.Adds it to the central whitelist (workflow inline regex + docs/license-whitelist.md), alongside tqdm. Unblocks license-check on ovos-persona#192 and any other repo resolving language data.
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
marisa-trieas an approved package, with justification for its compatible license status.Chores
marisa-trieis treated the same as other already-allowed license-flagged packages.