fix(license-check): self-exclude matches underscore + hyphen name forms - #52
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesLicense Check Workflow – Self-exclusion Regex
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #50. The self-package exclude anchors the pip-canonical (hyphenated) name, but pilosus/pip-licenses sometimes reports the resolved requirement with underscores (e.g.
ovos_stt_plugin_azure==1.0). A hyphen-only anchor then misses it and the self-package red-fails asError. Make each separator in the anchor match any of-_.so both forms are excluded. Removes the need for per-repo underscore self-package workarounds.Summary by CodeRabbit