loaded nml_doc used, memory saved #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pgleeson the
nml_docwas passed and then reloded (which took a lot of memory in the case of the hippocampal network) hence in pyNeuroMLnml_doccan be passed to avoid reloading.I've also replaced passing
networkwith only passingnetwork.idto save RAM,added option to not copy the network.nml file and plus one seed form lems as it is in the latest pynml.
You might update the example scipts to use the restructured
generate_lems_simulation(), but I can do that if you merge this in an other pull request.