ci: fix silently failing storybook build

[Khoyo]

Storybook tries to read stdin to when it fails (to get telemetry opt-in). If stdin is closed, it fails succesfully... Setting CI=true disable this behavior (and other similar ones), and it's a good practice to have it set anyway.

See https://github.com/OpenRailAssociation/osrd/actions/runs/15485923418/job/43600490309

[Synar]

Nice find!

(I doubt generate licenses will fail any time soon, but I doubt giving it CI=true will cause any problem either ^^)

[emersion]

This sounds a bit fragile to me, setting CI=true in a Docker image used for local development and rely on its implicit behavior…

Would STORYBOOK_DISABLE_TELEMETRY=1 work as an alternative? Would be more explicit and targeted.

(We should really report this as a storybook bug…)

[Khoyo]

This sounds a bit fragile to me, setting CI=true in a Docker image used for local development and rely on its implicit behavior…

Well, this image is used in the CI, and is in fact the one used in production. (And I wouldn't expect most people to build it to dev on the frontend, this is what dev-front is for)

Would STORYBOOK_DISABLE_TELEMETRY=1 work as an alternative? Would be more explicit and targeted.

It would, but wouldn't catch other potential mishaps in other components. Maybe we should set both, wdyt?

(We should really report this as a storybook bug…)

We should indeed. I didn't dig deeper to see what the exact culprit was though.

[Synar]

I'm working on a possible storybook side fix, but I'm unsure if it will be accepted

[Synar]

See storybookjs/storybook#31781

There may be something deeper too.

[emersion]

Well, this image is used in the CI, and is in fact the one used in production. (And I wouldn't expect most people to build it to dev on the frontend, this is what dev-front is for)

It's used by default when building OSRD.

CI would be correct to set as an env variable from the GitHub Action manifest, but not from the Dockerfile.

We want the build to fail as expected outside of CI, too.

It would, but wouldn't catch other potential mishaps in other components. Maybe we should set both, wdyt?

The logic to detect the CI env var is open-coded specifically for the telemetry. Just like isatty was forgotten here, checking for CI could be forgotten elsewhere too. So I don't think it buys a lot of safety.

[Synar]

See storybookjs/storybook#31781

There may be something deeper too.

This was merged, as soon as it gets released I'll open a bump pr