gateway: stop building the front from a subshell#12037
Closed
Synar wants to merge 3 commits into
Closed
Conversation
Synar
force-pushed
the
ali/fix-storybook-build-failing-silently-in-ci
branch
from
5ddf59a to
a0c80f6
Compare
This lead to the ci failing to build the front silently Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Synar
force-pushed
the
ali/fix-storybook-build-failing-silently-in-ci
branch
from
a0c80f6 to
71d9966
Compare
Khoyo
reviewed
Jun 6, 2025
| echo '<html><body><h1>No front, as this image was built for running it in dev mode</h1></body></html>' > build/index.html; \ | ||
| else \ | ||
| (npm run generate-licenses && npm run build); \ | ||
| npm run generate-licenses && npm run build; \ |
Contributor
There was a problem hiding this comment.
I'm not sure what the subshell would have to do with anything
Contributor
Author
There was a problem hiding this comment.
I should have marked this as draft haha
This was a guess at the issue,
I'm trying stuff and seeing what get the ci to fail and pass when it should ^^''
Contributor
|
Superseded by #12041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shouldn't change behavior
The ci silently failing is unrelated, due to storybook failing silently itself when unable to read std in ^^'' (thanks to @Khoyo for figuring that out!)