Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win32: Don't rely on timeout at all #2350

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

win32: Don't rely on timeout at all #2350

wants to merge 2 commits into from

Commits on Dec 29, 2019

  1. win32: Don't run cleanup if we're about to exit anyway 

    If the process is about to exit, there's no point trying to do
a bunch of work to clean up resources. The kernel will release
them much more efficiently when the process exits at the end
of this function.
    @Keno
    Keno committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    b16fa2e View commit details
    Browse the repository at this point in the history

  2. win32: Properly wait unil the thread finishes in dll unload 

    Without this we run into a problem. After 50ms we forcably kill
the pool thread. However, if the pool thread currently holds the
allocation lock, but doesn't get scheduled within 50ms, said lock
will never be released causing an infinite deadlock and preventing
the DLL from releasing. Further, in the unload scenario (as opposed
to process exit), we may actually want to let the thread pool finish
in case it's working on finishing an operation on another thread
(since the user may be expecting the answer).
    @Keno
    Keno committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    b89aef2 View commit details
    Browse the repository at this point in the history