Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix missing entites in shared report (#8333) #8587

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Oct 3, 2024

Proposed changes

  • check if granted ref relation is possible for Organization before relation creation (to avoid backend error)
  • specified that Organization and Sector are not concerned by stix ref instead of considering all Identity
  • add organization sharing test => 2 update organizations
  • add a json report file => 8create / 8delete / )
  • counters:
  • 9 create ( 1 report + 8 entites )
  • 6 update (orga sharing)
  • 9 delete

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (dae148d) to head (4a0e139).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8587      +/-   ##
==========================================
+ Coverage   66.07%   66.29%   +0.22%     
==========================================
  Files         597      597              
  Lines       60913    60916       +3     
  Branches     6204     6251      +47     
==========================================
+ Hits        40246    40382     +136     
+ Misses      20667    20534     -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact force-pushed the issue/8333_2 branch 2 times, most recently from 77c7c35 to 361c782 Compare October 6, 2024 14:14
@marieflorescontact marieflorescontact self-assigned this Oct 6, 2024
@marieflorescontact marieflorescontact marked this pull request as ready for review October 7, 2024 06:02
@marieflorescontact marieflorescontact changed the title Issue/8333 2 [backend] Missing entites in shared report (#8333) Oct 7, 2024
@marieflorescontact marieflorescontact changed the title [backend] Missing entites in shared report (#8333) [backend] Fix missing entites in shared report (#8333) Oct 7, 2024
@marieflorescontact marieflorescontact force-pushed the issue/8333_2 branch 2 times, most recently from c4d9775 to 35b9017 Compare October 14, 2024 06:29
@marieflorescontact marieflorescontact merged commit f65806d into master Oct 17, 2024
6 checks passed
@marieflorescontact marieflorescontact deleted the issue/8333_2 branch October 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants