Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] multi-repository PR should default as PR target branch and not master #8656

Closed
aHenryJard opened this issue Oct 14, 2024 · 0 comments · Fixed by #8732
Closed

[CI] multi-repository PR should default as PR target branch and not master #8656

aHenryJard opened this issue Oct 14, 2024 · 0 comments · Fixed by #8732
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) test automation use to identify issue related to test automation implementation
Milestone

Comments

@aHenryJard
Copy link
Member

Description

On ci build, the default target branch is hard coded as master. It's not working for PR that target for example release/6.4.0. TheCI script need some update to default to PR target branch.

Environment

  1. OS (where OpenCTI server runs): { e.g. Mac OS 10, Windows 10, Ubuntu 16.4, etc. }
  2. OpenCTI version: { e.g. OpenCTI 1.0.2 }
  3. OpenCTI client: { e.g. frontend or python }
  4. Other environment details:

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. { e.g. Run ... }
  2. { e.g. Click ... }
  3. { e.g. Error ... }

Expected Output

Actual Output

Additional information

Screenshots (optional)

@aHenryJard aHenryJard added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Oct 14, 2024
@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Oct 16, 2024
@nino-filigran nino-filigran added this to the Bugs backlog milestone Oct 18, 2024
@aHenryJard aHenryJard self-assigned this Oct 22, 2024
@aHenryJard aHenryJard added the test automation use to identify issue related to test automation implementation label Oct 22, 2024
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) test automation use to identify issue related to test automation implementation
Projects
None yet
3 participants