This repository was archived by the owner on Mar 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 282
(#1785) Update test_framework.py to support version compatibility tests #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c110900
to
fdf79f5
Compare
64c8f27
to
2452072
Compare
@cpacia are there any tests being run against different versions in this PR so far? |
46 tasks
Implement Ethereum
…-purchases Fix scientific notation coming out of database for purchases
Check for nil blocknumber when retrieving tx
Changed ReleaseFunds func to check if transaction goes through before saving
This will take a string and encode it as a multihash + convert it to a Base 58 string in the same way we do to our coupons. This makes it easy for clients to determine if a given coupon matches a listing's coupon secret.
feat: Endpoint to hash a message
…ogressed Also automatically progress an order contract's state to RESOLVED when a DISPUTE_CLOSE message is found and DisputeAcceptance data is already present on the contract. This is another fix aimed at fully resolving #1651
Fix: Save DisputeAcceptance to the contract no matter what
Save and load unconfirmed txs from db
v4 tests:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ethereum
Ethereum integration-related issues.
internal
Under-the-hood issues
🔍 readyForReview
Issue or PR ready for code review prior to closing.
🚀 🚫
Launch blockers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of running tests is:
This way still works, but a new option is available:
Where
i
is a list of string paths for each ob-go binary that is used. The binaries can be different versions. The number of binaries in the list must be equal to the number of nodes created by the test and the index of the binary string must map to the node (buyer, vendor, moderator) that you want it to map to.This PR is technically incomplete as it only allows the use of multiple binaries, however all the test data is currently formatted using the current version and not prior versions. Getting the old version shouldn't be difficult as it's just copying and pasting the test data from the old version. However, each test will need to be updated to decide which version of the data file it needs to load and post to the server.
I've added another flag
-v
that can be used to specify the versions which map to each node. For example:`-v v1 v2 v2`
Means that node 0 is a v1 node and nodes 2 and 3 are v2 nodes. Each test would need to do something like: