Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Save and load unconfirmed txs from db #2034

Merged
merged 5 commits into from
Mar 18, 2020
Merged

Save and load unconfirmed txs from db #2034

merged 5 commits into from
Mar 18, 2020

Conversation

@cpacia
Copy link
Member

@cpacia cpacia commented Mar 13, 2020 •
edited
Loading

Closes #2024

@coveralls
Copy link

coveralls commented Mar 13, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 41.502% when pulling fa5e79b on ethunconf into 467aecf on master.

@drwasho drwasho added ethereum Ethereum integration-related issues. 🔍 readyForReview Issue or PR ready for code review prior to closing. labels Mar 16, 2020
@drwasho drwasho requested a review from hoffmabc March 16, 2020 01:55
@drwasho
Copy link
Member

drwasho commented Mar 16, 2020

Still not seeing pending outgoing transactions in the GET /wallet/transactions/:teth list; seeing this in the terminal:

2020-03-16 18:51:49.453 [INFO] [ethwallet/checkTxnRcpt] fetching txn rcpt: not found
2020-03-16 18:51:54.451 [INFO] [ethwallet/checkTxnRcpt] fetching txn rcpt: not found
2020-03-16 18:51:59.459 [INFO] [transaction-listener/OnTransactionReceived] Transaction received 0xf1e57c4d17753988ce660b5228049b2b5214ef394772ded6465e55cd245efbd6 6147041
2020-03-16 18:51:59.459 [DEBUG] [transaction-listener/OnTransactionReceived] tx metadata not found for id (0xf1e57c4d17753988ce660b5228049b2b5214ef394772ded6465e55cd245efbd6): sql: no rows in result set
2020-03-16 18:52:05.071 [INFO] [transaction-listener/OnTransactionReceived] Transaction received 0xf1e57c4d17753988ce660b5228049b2b5214ef394772ded6465e55cd245efbd6 6147041
2020-03-16 18:52:05.071 [DEBUG] [transaction-listener/OnTransactionReceived] tx metadata not found for id (0xf1e57c4d17753988ce660b5228049b2b5214ef394772ded6465e55cd245efbd6): sql: no rows in result set

But I suspect I'm testing before this is ready?

@drwasho drwasho added 🚧 in progress Issue or PR is currently being worked on and not in final form. and removed 🔍 readyForReview Issue or PR ready for code review prior to closing. labels Mar 16, 2020
@cpacia cpacia merged commit aa0fd46 into master Mar 18, 2020
@hoffmabc hoffmabc deleted the ethunconf branch April 6, 2020 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoffmabc hoffmabc Awaiting requested review from hoffmabc

Assignees

No one assigned

Labels

ethereum Ethereum integration-related issues. 🚧 in progress Issue or PR is currently being worked on and not in final form.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug (ETH): GET /wallet/transactions/eth fails to return unconfirmed and pending state txs

4 participants

@cpacia @coveralls @drwasho