Haskell-http-generator - Make endpoints which don't return anything yield NoContent #9916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9901
The haskell-http-client generator tries to generate a polymorphic return type for endpoints which don't return anything in the success case, but still produce content in other cases. This means that these endpoints hit a decoding error in the success case, because there is no content to decode.
This changes the behaviour so that endpoints that don't return anything are always generated as returning NoContent, and never try to decode the response. This change is based on a similar one for the haskell-servant generator, which can be found at #9830, which resolved a similar issue for that generator.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x