[BUG][Haskell] Fix returning NoContent #9830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that failing tests are on C# code only. |
|
Tested locally with updated samples and the result is good: |
Closed
6 tasks
ivanbakel
added a commit
to ivanbakel/openapi-generator
that referenced
this pull request
Jul 8, 2021
Relevant issue: OpenAPITools#9901 The haskell-http-client generator tries to generate a polymorphic return type for endpoints which don't return anything in the success case, but still produce content in other cases. This means that these endpoints hit a decoding error in the success case, because there is no content to decode. This changes the behaviour so that endpoints that don't return anything are *always* generated as returning NoContent, and never try to decode the response. This change is based on a similar one for the haskell-servant generator, which can be found at: OpenAPITools#9830 which resolved a similar issue for that generator.
5 tasks
wing328
changed the title
jonschoning
pushed a commit
that referenced
this pull request
Jul 15, 2021
…ield NoContent (#9916) * Make endpoints which don't return anything yield NoContent Relevant issue: #9901 The haskell-http-client generator tries to generate a polymorphic return type for endpoints which don't return anything in the success case, but still produce content in other cases. This means that these endpoints hit a decoding error in the success case, because there is no content to decode. This changes the behaviour so that endpoints that don't return anything are *always* generated as returning NoContent, and never try to decode the response. This change is based on a similar one for the haskell-servant generator, which can be found at: #9830 which resolved a similar issue for that generator. * Update samples after haskell-http-client NoContent change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verbs with no content returned are now shown as having return type of
(). This makesservantto try to parse resulting object.Thus replacement with
NoContenttype fixes the issue.Fixes: #9829
@wing328 @jimschubert @burberius