Add hashableModels to additional properties #9495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 18053af.
maoyama
force-pushed
the
add-hashableStruct-to-additional-properties
branch
from
977243a
to
a0bce08
Compare
maoyama
force-pushed
the
add-hashableStruct-to-additional-properties
branch
from
a0bce08
to
e525215
Compare
maoyama
changed the title
|
@maoyama Thanks for opening this PR. But could you please rename the option |
- Replace hashableStruct => hashableModels - Replace HashableStruct => HashableModels - Replace HASHABLE_STRUCT => HASHABLE_MODELS - Update docs
|
@4brunu You’re right. |
maoyama
changed the title
4brunu
reviewed
May 18, 2021
| @@ -1,4 +1,4 @@ | |||
| {{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{classname}}: Codable, Hashable { | |||
| {{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{classname}}: Codable{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}} { | |||
There was a problem hiding this comment.
@maoyama shouldn't we also check here for {{#hashableModels}}...{{/hashableModels}}?
There was a problem hiding this comment.
@4brunu We don't have to check here.
I set x-swift-hashable to true when hashableModels is true to reduce the logic in modelObject.mustache. fb2c45f
|
Looks good to me, let's wait for the CI to finish |
|
CI is failing, but it's not related to this PR. |
premiumitsolution
pushed a commit
to premiumitsolution/openapi-generator
that referenced
this pull request
May 26, 2021
* Add hashableStruct * Revert "Remove x-swift-hashable" This reverts commit 18053af. * Add Hashable for x-swift-hashable * Add config yaml to test x-swift-hashable * Run ./bin/generate-samples.sh ./bin/configs/swift5* * Run ./bin/utils/export_docs_generators.sh * Run ./bin/generate-samples.sh ./bin/configs/swift5* * Verify setHashableStruct * Rename hashableStruct => hashableModels - Replace hashableStruct => hashableModels - Replace HashableStruct => HashableModels - Replace HASHABLE_STRUCT => HASHABLE_MODELS - Update docs * Refactor modelObject.mustache * Control equals and hash functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9473 , Related #9166
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)