Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ][swift5] Add config flag to control Hashable conformance behavior #9473

Closed
fl034 opened this issue May 13, 2021 · 0 comments · Fixed by #9495
Closed

[REQ][swift5] Add config flag to control Hashable conformance behavior #9473

fl034 opened this issue May 13, 2021 · 0 comments · Fixed by #9495

Comments

@fl034
Copy link
Contributor

fl034 commented May 13, 2021

Is your feature request related to a problem? Please describe.

In v5.1.1 #9166 introduced a new default behavior that adopts Hashable for every model via synthetization. That way custom implementations won't be called anymore.

Describe the solution you'd like

After talking with @4brunu we decided that a config flag to control the behavior in general would be good.
On model level you can always use the x-swift-hashable: true to enable Hashable conformance.

We should discuss if the feature should be enabled or disabled as default.

Describe alternatives you've considered

Multiple alternatives would be possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant