[docker] Fixes hub dockerfile for online project #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update was made in #876 to remove version from the generated artifact for openapi-generator-online. The change is missing the -online suffix. My original glob pattern put the * in the wrong place for maintainability.
jmini
approved these changes
Aug 28, 2018
|
Thanks for reviewing! |
|
Master builds appear to be working as expected (see https://hub.docker.com/r/openapitools/openapi-generator/builds/). @jmini @wing328 I haven't merged anything into the 3.3.x and 4.0.x branches to test those, because I wasn't sure how their merges are being handled. I'd propose after next week's revision release, we look at how we might consolidate https://hub.docker.com/r/openapitools/openapi-generator-cli/ and https://hub.docker.com/r/openapitools/openapi-generator-online/ (even if it's potentially triggering a build based on the openapi-generator image's build). |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
An update was made in OpenAPITools#876 to remove version from the generated artifact for openapi-generator-online. The change is missing the -online suffix. My original glob pattern put the * in the wrong place for maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update was made in #876 to remove version from the generated artifact
for openapi-generator-online. The change is missing the -online suffix.
My original glob pattern put the * in the wrong place for
maintainability.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.