[build] create jar without version in openapi-generator-online #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify other scripts needing this jar Consistent with openapi-generator-cli
wing328
approved these changes
Aug 24, 2018
|
Docker image tested with: http://localhost:8989/ is responding. |
jimschubert
added a commit
that referenced
this pull request
Aug 28, 2018
An update was made in #876 to remove version from the generated artifact for openapi-generator-online. The change is missing the -online suffix. My original glob pattern put the * in the wrong place for maintainability.
4 tasks
jmini
commented
Aug 28, 2018
| @@ -26,7 +26,7 @@ RUN mkdir -p ${TARGET_DIR} | |||
|
|
|||
| WORKDIR ${TARGET_DIR} | |||
|
|
|||
| COPY --from=builder ${GEN_DIR}/modules/openapi-generator-online/target/openapi-generator-*.jar ${TARGET_DIR}/openapi-generator-online.jar | |||
| COPY --from=builder ${GEN_DIR}/modules/openapi-generator-online/target/openapi-generator.jar ${TARGET_DIR}/openapi-generator-online.jar | |||
There was a problem hiding this comment.
should be openapi-generator-online/target/openapi-generator-online.jar => See #914
jimschubert
added a commit
that referenced
this pull request
Aug 28, 2018
An update was made in #876 to remove version from the generated artifact for openapi-generator-online. The change is missing the -online suffix. My original glob pattern put the * in the wrong place for maintainability.
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…PITools#876) Simplify other scripts needing this jar Consistent with openapi-generator-cli
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
An update was made in OpenAPITools#876 to remove version from the generated artifact for openapi-generator-online. The change is missing the -online suffix. My original glob pattern put the * in the wrong place for maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of:
The
openapi-generator-onlineartifact is locally generated at:This is much simpler for other scripts and Dockerfiles, relying on this jar.
This way we are consistent with the
openapi-generator-cliartifact.