Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Webclient] Init authentication on ApiClient instantiation #887

Merged
merged 3 commits into from
Aug 25, 2018

Conversation

marcoreni
Copy link
Contributor

@marcoreni marcoreni commented Aug 23, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Description of the PR

Fixes #872 .

I changed ApiClient() declaration for DRY.
NVM, this() must be first line.

Testing is being discussed in #689

Copy link
Member

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I let some time for others to review.

@jmini jmini merged commit 39e9206 into OpenAPITools:master Aug 25, 2018
@jmini jmini added this to the 3.2.3 milestone Aug 25, 2018
@jmini
Copy link
Member

jmini commented Aug 25, 2018

Thank you a lot for this contribution!

@marcoreni marcoreni deleted the fix/872 branch August 27, 2018 15:57
@wing328 wing328 changed the title [Java][Webclient] Init authentication on ApiClient instanciation [Java][Webclient] Init authentication on ApiClient instantiation Aug 30, 2018
@wing328
Copy link
Member

wing328 commented Aug 30, 2018

@marcoreni thanks for the PR, which has been included in the v3.2.3 release: https://twitter.com/oas_generator/status/1035200785066254336

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants