Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA][Webclient] Add constructor to allow custom WebClient to be passed into ApiClient #882

Merged
merged 7 commits into from
Aug 25, 2018
Merged

[JAVA][Webclient] Add constructor to allow custom WebClient to be passed into ApiClient #882

merged 7 commits into from
Aug 25, 2018

Conversation

hfgbarrigas
Copy link
Contributor

@hfgbarrigas hfgbarrigas commented Aug 23, 2018

Description of the PR

Add apiclient constructor allowing custom webclient to be used.

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Fixes #874

Copy link
Member

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I let some time for others to review.

@jmini jmini changed the title Custom webclient [JAVA][Webclient] Add constructor to allow custom WebClient to be passed into ApiClient Aug 23, 2018
@hfgbarrigas
Copy link
Contributor Author

Edit: Actually call init() to properly add authentications.

@jmini
Copy link
Member

jmini commented Aug 25, 2018

I have merged origin/master into this PR (to solve conflicts introduced by #887)

@jmini jmini merged commit 37fd426 into OpenAPITools:master Aug 25, 2018
@jmini
Copy link
Member

jmini commented Aug 25, 2018

Thank you a lot for this contribution

@hfgbarrigas hfgbarrigas deleted the custom_webclient branch August 27, 2018 10:19
@wing328
Copy link
Member

wing328 commented Aug 30, 2018

@hfgbarrigas thanks for the PR, which has been included in the v3.2.3 release: https://twitter.com/oas_generator/status/1035200785066254336

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…sed into ApiClient (OpenAPITools#882)

* add constructor to allow custom webclient to be passed into ApiClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JAVA][Webclient] Add constructor to allow custom WebClient to be passed into ApiClient.
3 participants