Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scala-akka-client] Scala Akka client does not support arbitrary query string parameters #8610

Closed

Conversation

ameenhaq
Copy link
Contributor

@ameenhaq ameenhaq commented Feb 4, 2021

Scala Akka client ApiRequest (mustache file) includes functionality to take Map type query string parameters. The paramCreation, has been modified to check the input and serialise the input as Map (when condition is satisfied) with the introduction of a simple conditional statement to check if it isMap type.

This PR is a solution for the issue #8606.

PR checklist

  • [✅] Read the contribution guidelines.
  • [✅] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [✅] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [✅] File the PR against the correct branch: master, 5.1.x, 6.0.x
  • [✅] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ameenhaq ameenhaq changed the title Add check for input if is Map type [scala-akka-client] Scala Akka client does not support arbitrary query string parameters #8606 Feb 4, 2021
@ameenhaq ameenhaq changed the title [scala-akka-client] Scala Akka client does not support arbitrary query string parameters #8606 [scala-akka-client] Scala Akka client does not support arbitrary query string parameters Feb 4, 2021
@wing328
Copy link
Member

wing328 commented Feb 5, 2021

cc @clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)

@wing328
Copy link
Member

wing328 commented Feb 5, 2021

Please run the following to update the samples:

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

@wing328 wing328 modified the milestones: 5.0.1, 5.1.0 Feb 8, 2021
@chameleon82
Copy link
Contributor

As there is no generated example could you please create unit test?

@wing328 wing328 modified the milestones: 5.1.0, 5.1.1 Mar 19, 2021
.withQueryParam(filters)
.withSuccessResponse[Seq[Pet]](200)
.withErrorResponse[Unit](400)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this method to samples/client/petstore/scala-akka/src/test/scala/PetApiTest.scala instead.

@@ -20,7 +20,7 @@ import org.openapitools.client.core.ApiKeyLocations._

object PetApi {

def apply(baseUrl: String = "http://petstore.swagger.io/v2") = new PetApi(baseUrl)
def apply(baseUrl: String = "https://petstore.swagger.io/v2") = new PetApi(baseUrl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change as the local instance of the petstore server doesn't support https

@wing328
Copy link
Member

wing328 commented Dec 13, 2023

merged via #17386

@wing328 wing328 closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants