-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scala-akka-client] Scala Akka client does not support arbitrary query string parameters #8610
[scala-akka-client] Scala Akka client does not support arbitrary query string parameters #8610
Conversation
cc @clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) |
Please run the following to update the samples:
|
As there is no generated example could you please create unit test? |
.withQueryParam(filters) | ||
.withSuccessResponse[Seq[Pet]](200) | ||
.withErrorResponse[Unit](400) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this method to samples/client/petstore/scala-akka/src/test/scala/PetApiTest.scala
instead.
@@ -20,7 +20,7 @@ import org.openapitools.client.core.ApiKeyLocations._ | |||
|
|||
object PetApi { | |||
|
|||
def apply(baseUrl: String = "http://petstore.swagger.io/v2") = new PetApi(baseUrl) | |||
def apply(baseUrl: String = "https://petstore.swagger.io/v2") = new PetApi(baseUrl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change as the local instance of the petstore server doesn't support https
merged via #17386 |
Scala Akka client
ApiRequest
(mustache file) includes functionality to take Map type query string parameters. TheparamCreation
, has been modified to check the input and serialise the input as Map (when condition is satisfied) with the introduction of a simple conditional statement to check if itisMap
type.This PR is a solution for the issue #8606.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x